[MDEV-15530] Variable replicate_rewrite_db cannot be found in "show global variables" Created: 2018-03-09  Updated: 2023-08-07  Resolved: 2022-10-21

Status: Closed
Project: MariaDB Server
Component/s: Replication, Variables
Fix Version/s: 10.11.1

Type: Task Priority: Critical
Reporter: Aurélien LEQUOY Assignee: Anel Husakovic
Resolution: Fixed Votes: 0
Labels: Preview_10.11

Issue Links:
Duplicate
is duplicated by MDEV-5779 replicate-rewrite-db additions at run... Closed
is duplicated by MDEV-10909 Enable replicate-rewrite-db in multi ... Closed
is duplicated by MDEV-17165 replicate-rewrite-db Closed
PartOf
is part of MDEV-29547 prepare 10.11.0 preview releases Closed
Problem/Incident
causes MDEV-29792 Update Replication Variables for Mult... Closed
Relates
relates to MDEV-29348 rpl.rpl_rewrt_db test fails with [gdb... Closed

 Description   

Hello,

It's many time I asked myself but I never found answer about that, why we cannot find the variable : replicate_rewrite_db in "show global variables" or "show all slaves stauts" <- (should be there)

MariaDB [(none)]> show global variables like '%replicate%';
 
+----------------------------------+-----------+
 
| Variable_name                    | Value     |
 
+----------------------------------+-----------+
 
| replicate_annotate_row_events    | ON        |
 
| replicate_do_db                  |           |
 
| replicate_do_table               |           |
 
| replicate_events_marked_for_skip | REPLICATE |
 
| replicate_ignore_db              |           |
 
| replicate_ignore_table           |           |
 
| replicate_wild_do_table          |           |
 
| replicate_wild_ignore_table      |           |
 
| wsrep_replicate_myisam           | OFF       |
 
+----------------------------------+-----------+
 
9 rows in set (0.005 sec)



 Comments   
Comment by Elena Stepanova [ 2018-07-09 ]

That's because it's not a variable, it's a command-line option only.
https://mariadb.com/kb/en/library/replication-and-binary-log-server-system-variables/#replicate_rewrite_db

Do you want it to be converted into a feature request for making it a variable?

Comment by Aurélien LEQUOY [ 2018-08-06 ]

Hello Elena,

Yes, can you add this to be converted into a feature request for making it a variable.

without this you need reboot server each time, and it's not fair at all when you have many thread of replication.

Comment by Aurélien LEQUOY [ 2018-08-08 ]

so it's will be add or not ?

Comment by Sergei Golubchik [ 2018-08-08 ]

At the moment it's not planned for any specific release (see above, FixVersion is empty). But eventually it will be added.

Comment by Dixit Patel [ 2018-10-11 ]

Hi, I was trying to search through the code base to get a starting point for this fix. I was looking through mysql.cc inside client directory, but don't know if this is a good place to start. Any inputs ?
I'm only getting started with Mariadb codebase so I'd appreciate any help.

Comment by Daniel Black [ 2018-10-18 ]

sql/mysqld.cc contains the command line options. variables are in sql/sys_vars.cc. Ignore the client directory - its programs like the mysql client, mysqldump etc. Most things you'll need are in sql/.

Comment by Rodrigo Souza [ 2020-10-06 ]

I wonder if there is somebody working on this feature request? If not, I'd like to tackle it.

Comment by Sergei Golubchik [ 2020-11-04 ]

Nobody is working on it, as far as I can see. Feel free to do it.
Thanks!

Comment by Aurélien LEQUOY [ 2022-08-04 ]

if any could work on it <3

Comment by Brandon Nesterenko [ 2022-09-01 ]

Hi anel!

Thanks for the patch! I left review notes on Github.

Comment by Anel Husakovic [ 2022-09-30 ]

SHOW SLAVE STATUS currently (10.11<=) doesn't output replicate_rewrite_db.
With this patch we should support also that replicate_rewrite_db can be shown in show slave status command output.

Comment by Angelique Sklavounos (Inactive) [ 2022-10-14 ]

76e4bb64d7 OK to push

Comment by Brandon Nesterenko [ 2022-10-21 ]

Pushed into 10.11 on behalf of Anel, who is on leave.

Comment by Aurélien LEQUOY [ 2022-10-22 ]

MariaDB 10.11 ?

I even didn't check since 10.9 lol

Generated at Thu Feb 08 08:22:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.