[MDEV-15444] Querying I_S.PARAMETERS can crash with a corrupted mysql.proc Created: 2018-03-01  Updated: 2018-03-02  Resolved: 2018-03-02

Status: Closed
Project: MariaDB Server
Component/s: Stored routines
Affects Version/s: 10.3
Fix Version/s: 10.3.6

Type: Bug Priority: Major
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None


 Description   

I intentionally break mysql.proc by adding an extra value into the type column, and update type of an existing routine to the new bad value. After this change, a query to I_S.PARAMETERS crashes the server.

CREATE OR REPLACE FUNCTION f1 (a INT) RETURNS INT RETURN 10;
ALTER TABLE mysql.proc MODIFY type enum('FUNCTION','PROCEDURE','PACKAGE','PACKAGE BODY','XXX');
UPDATE mysql.proc SET type='XXX' WHERE name='f1';
SELECT * FROM INFORMATION_SCHEMA.PARAMETERS;

This problem was introduced by the patch for MDEV-13415.



 Comments   
Comment by Elena Stepanova [ 2018-03-01 ]

Stack trace to make it searchable

10.3 92993d92e

#1  0x000056118feb1bc5 in my_write_core (sig=11) at /home/elenst/server/mysys/stacktrace.c:481
#2  0x000056118f6e227b in handle_fatal_signal (sig=11) at /home/elenst/server/sql/signal_handler.cc:305
#3  <signal handler called>
#4  0x000056118f32c314 in sp_cache_lookup (cp=0x0, name=0x7f46c8636d60) at /home/elenst/server/sql/sp_cache.cc:195
#5  0x000056118f86e653 in Sp_handler::sp_load_for_information_schema (this=0x561190b6d390 <sp_handler_trigger>, thd=0x7f46ac000b00, proc_table=0x7f46ac029860, db=..., name=..., params=..., returns=..., sql_mode=1411383296, free_sp_head=0x7f46c863857e) at /home/elenst/server/sql/sp.cc:2990
#6  0x000056118f4a3a5a in store_schema_params (thd=0x7f46ac000b00, table=0x7f46ac02c538, proc_table=0x7f46ac029860, wild=0x0, full_access=true, sp_user=0x7f46c8639a30 "root@localhost") at /home/elenst/server/sql/sql_show.cc:6228
#7  0x000056118f4a5097 in fill_schema_proc (thd=0x7f46ac000b00, tables=0x7f46ac014f90, cond=0x0) at /home/elenst/server/sql/sql_show.cc:6484
#8  0x000056118f4aea5c in get_schema_tables_result (join=0x7f46ac016978, executed_place=PROCESSED_BY_JOIN_EXEC) at /home/elenst/server/sql/sql_show.cc:8673
#9  0x000056118f449664 in JOIN::exec_inner (this=0x7f46ac016978) at /home/elenst/server/sql/sql_select.cc:3950
#10 0x000056118f448d0a in JOIN::exec (this=0x7f46ac016978) at /home/elenst/server/sql/sql_select.cc:3781
#11 0x000056118f449f42 in mysql_select (thd=0x7f46ac000b00, tables=0x7f46ac014f90, wild_num=1, fields=..., conds=0x0, og_num=0, order=0x0, group=0x0, having=0x0, proc_param=0x0, select_options=2684619520, result=0x7f46ac016958, unit=0x7f46ac004938, select_lex=0x7f46ac0050b0) at /home/elenst/server/sql/sql_select.cc:4186
#12 0x000056118f43c298 in handle_select (thd=0x7f46ac000b00, lex=0x7f46ac004870, result=0x7f46ac016958, setup_tables_done_option=0) at /home/elenst/server/sql/sql_select.cc:382
#13 0x000056118f4073ae in execute_sqlcom_select (thd=0x7f46ac000b00, all_tables=0x7f46ac014f90) at /home/elenst/server/sql/sql_parse.cc:6552
#14 0x000056118f3fd6ee in mysql_execute_command (thd=0x7f46ac000b00) at /home/elenst/server/sql/sql_parse.cc:3763
#15 0x000056118f40ad5c in mysql_parse (thd=0x7f46ac000b00, rawbuf=0x7f46ac014d48 "SELECT * FROM INFORMATION_SCHEMA.PARAMETERS", length=43, parser_state=0x7f46c863b5d0, is_com_multi=false, is_next_command=false) at /home/elenst/server/sql/sql_parse.cc:8009
#16 0x000056118f3f8148 in dispatch_command (command=COM_QUERY, thd=0x7f46ac000b00, packet=0x7f46ac090131 "SELECT * FROM INFORMATION_SCHEMA.PARAMETERS", packet_length=43, is_com_multi=false, is_next_command=false) at /home/elenst/server/sql/sql_parse.cc:1838
#17 0x000056118f3f6b80 in do_command (thd=0x7f46ac000b00) at /home/elenst/server/sql/sql_parse.cc:1383
#18 0x000056118f55a1b0 in do_handle_one_connection (connect=0x561192430c90) at /home/elenst/server/sql/sql_connect.cc:1402
#19 0x000056118f559f30 in handle_one_connection (arg=0x561192430c90) at /home/elenst/server/sql/sql_connect.cc:1308
#20 0x000056118fa49e74 in pfs_spawn_thread (arg=0x5611924fd220) at /home/elenst/server/storage/perfschema/pfs.cc:1862
#21 0x00007f46ce8da6ba in start_thread (arg=0x7f46c863c700) at pthread_create.c:333
#22 0x00007f46cdd6f41d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Comment by Alexander Barkov [ 2018-03-02 ]

Pushed to bb-10.2-ext and 10.3.

Generated at Thu Feb 08 08:21:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.