[MDEV-15073] Generic UDAF parser code in server for windows functions Created: 2017-12-13 Updated: 2018-12-11 Resolved: 2018-11-27 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Fix Version/s: | 10.4.1 |
| Type: | Task | Priority: | Critical |
| Reporter: | Andrew Hutchings (Inactive) | Assignee: | Oleksandr Byelkin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
We currently have a patched in MariaDB's parser to support UDAFs. We need to work with the server team to do this in a more generic way. |
| Comments |
| Comment by Andrew Hutchings (Inactive) [ 2018-01-25 ] | ||||||||||||||||||||||||||||||
|
Current patch used by ColumnStore for UDAF window functions:
| ||||||||||||||||||||||||||||||
| Comment by Oleksandr Byelkin [ 2018-11-16 ] | ||||||||||||||||||||||||||||||
|
UDAF == User Defined Aggregate Function | ||||||||||||||||||||||||||||||
| Comment by Oleksandr Byelkin [ 2018-11-16 ] | ||||||||||||||||||||||||||||||
|
The problem I see is that window function need other interface than usual aggregate. | ||||||||||||||||||||||||||||||
| Comment by Oleksandr Byelkin [ 2018-11-20 ] | ||||||||||||||||||||||||||||||
|
For more efficient window functions support support of *_remove() call added to UDF, aggregate without it also supported as a window function. | ||||||||||||||||||||||||||||||
| Comment by Oleksandr Byelkin [ 2018-11-20 ] | ||||||||||||||||||||||||||||||
|
I forgot to change ORACLE parser, but there changes will be the same. | ||||||||||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2018-11-21 ] | ||||||||||||||||||||||||||||||
|
ok to push |