[MDEV-14965] 10.3 source tree does not build on an offline system Created: 2018-01-16  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2
Fix Version/s: 10.4

Type: Bug Priority: Major
Reporter: Otto Kekäläinen Assignee: VicenČ›iu Ciorbaru
Resolution: Unresolved Votes: 0
Labels: None

Attachments: File mariadb-10.3_build-d87531a6a05-offline.log     File mariadb-10.3_build-d87531a6a05-online.log    

 Description   

I noticed while working on an airplane that the current 10.3 source does not build on a laptop that is offline.

I have attached two build logs that are generated using the exactly same build command at the exactly same commit (). However, when my system was offline, the build failed. The issue is easily repeatable.

I consider this a bug. In most Linux distributions builds are done in offline systems due to security reasons. If a source does something online as part of the cmake build step, it is against the policy of most Linux distributions.

I've looked at the diff of the build logs online vs offline, but both versions have the same libtool related lines and I cannot figure out what is the actual error why the build stops.

 Comments   
Comment by Elena Stepanova [ 2018-01-16 ]

I'm setting affected version to 10.2, as I expect it will be the same in 10.2 due to the submodule situation; but not sure if it's easily fixable in 10.2, so setting fix version to 10.3.
Please feel free to adjust both values as you see fit.

Comment by Sergei Golubchik [ 2018-01-16 ]

Interesting part:

fatal: unable to access 'https://github.com/awslabs/aws-sdk-cpp.git/': Could not resolve host: github.com
 
Had to git clone more than once: 3 times.
 
CMake Error at aws_sdk_cpp-prefix/tmp/aws_sdk_cpp-gitclone.cmake:56 (message):
 
  Failed to clone repository: 'https://github.com/awslabs/aws-sdk-cpp.git'
 
 
 
plugin/aws_key_management/CMakeFiles/aws_sdk_cpp.dir/build.make:90: recipe for target 'plugin/aws_key_management/aws_sdk_cpp-prefix/src/aws_sdk_cpp-stamp/aws_sdk_cpp-download' failed

Comment by Otto Kekäläinen [ 2020-05-19 ]

The AWS SDK is not build by default anymore, so offline builds in normal situations work just like online builds (assuming one has the full .tar.gz as published by MariaDB, includes the git repo + submodules).

Comment by Otto Kekäläinen [ 2020-05-19 ]

If it is acknowledged that setups where there are something else than the original source + defined dependencies (that must exists as packages in common Linux distros and platforms) are to be avoided (such as, downloading on the fly external assets that are not in the source of explicit build dependencies) then this issue could be closed as regarding the AWS git clone there are no more action points here.

Generated at Thu Feb 08 08:17:40 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.