[MDEV-14918] Potential issue: sst_dump may already exist in Debian at installation time Created: 2018-01-11  Updated: 2020-04-14  Resolved: 2020-04-14

Status: Closed
Project: MariaDB Server
Component/s: Platform Debian
Affects Version/s: 10.3
Fix Version/s: 10.5.2

Type: Bug Priority: Trivial
Reporter: Otto Kekäläinen Assignee: Otto Kekäläinen
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-6284 Merge downstream Debian/Ubuntu packag... Closed

 Description   

In commit a421f0b6b8feb41a42fc4cedfcd549d8e681e47b sst_dump was added to the mariadb-plugin-rocksdb package.

This binary is also coming to Debian via the rocksdb-tools package. It is however currently now only in Debian experimental: https://packages.debian.org/experimental/rocksdb-tools

We might drop it from our package or make our package conflict with rocksdb-tools.

 Comments   
Comment by Otto Kekäläinen [ 2018-08-05 ]

It has now landed in Debian unstable, and will propagate from there to next Debian releases.
https://packages.debian.org/sid/rocksdb-tools

psergey Do we really have to build and this this tool ourselves or could we just use the one that is available in Linux distributions already?

Comment by Otto Kekäläinen [ 2018-12-25 ]

I never got a reply from psergey so nothing can be done about this. Therefore re-assigning to Sergei.

Comment by Otto Kekäläinen [ 2018-12-25 ]

See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886853

Comment by Otto Kekäläinen [ 2018-12-25 ]

and https://salsa.debian.org/mariadb-team/mariadb-10.3/commit/d50e2eaf1fad46c494bd0f090b0e75c19ac3f41a

Comment by Sergei Petrunia [ 2018-12-25 ]

Looking...

  1. MyRocks' sst_dump does not include any MyRocks-specific code.
  2. RocksDB's page about data compatibility: https://github.com/facebook/rocksdb/wiki/RocksDB-Compatibility-Between-Different-Releases. Debian includes RocksDB 5.17, MariaDB uses 5.14. So, rocksdb-lib's sst_dump will be able to read MyRocks' sst files
Comment by Sergei Petrunia [ 2018-12-25 ]

.. so I think both solutions (removing sst_dump from packaging and renaming it to mysql_sst_dump, like it was done with ldb->mysql_ldb) are acceptable.

Comment by Sergei Petrunia [ 2018-12-25 ]

otto, do I understand correctly that your patch removes sst_dump from MyRocks' package? (I think, this is ok). Will we need to merge this patch the MariaDB upstream repository? (or, what else there is to do for this MDEV?)

Comment by Otto Kekäläinen [ 2018-12-25 ]

Thanks for your analysis. Let's wait a bit for the change in Debian to become "battle-tested" and then upstream the same change.

Comment by Otto Kekäläinen [ 2020-02-24 ]

PR filed at https://github.com/MariaDB/server/pull/1451

Comment by Otto Kekäläinen [ 2020-04-14 ]

PR was merged, but Jira issue did not auto-update?

Anyway, this has been fixed since https://github.com/MariaDB/server/commit/f2832a010a4ab0ba1cd47cc378338731bf659328 landed.

Generated at Thu Feb 08 08:17:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.