[MDEV-14856] Inconsistency in automatic adding of executable comments for new column attributes Created: 2018-01-02  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.3
Fix Version/s: 10.4

Type: Bug Priority: Minor
Reporter: Elena Stepanova Assignee: Sergei Golubchik
Resolution: Unresolved Votes: 0
Labels: None


 Description   

There is no obvious logic in wrapping or not wrapping new attributes into versioned comments:

MariaDB [test]> create table t1 (pk int, c text compressed invisible);
Query OK, 0 rows affected (0.18 sec)
 
MariaDB [test]> show create table t1 \G
*************************** 1. row ***************************
       Table: t1
Create Table: CREATE TABLE `t1` (
  `pk` int(11) DEFAULT NULL,
  `c` text /*!100301 COMPRESSED*/ INVISIBLE DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1
1 row in set (0.00 sec)

Here COMPRESSED is wrapped (wrongly btw, since it was only pushed in 10.3.2), but INVISIBLE is not at all.

I have a plausible explanation for it: COMPRESSED is optional, because it doesn't change the application logic (much); but INVISIBLE might, so maybe it's better that it fails on servers which don't support invisible columns. However, I don't know if it was really meant this way.


Generated at Thu Feb 08 08:16:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.