[MDEV-14851] wsrep_sst_rsync (10.1+) reads mariadb-10.0 section of configuration file for innodb_log_group_home_dir Created: 2018-01-02 Updated: 2018-08-28 Resolved: 2018-06-14 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera SST |
| Affects Version/s: | 10.1, 10.2, 10.3 |
| Fix Version/s: | 10.1.34, 10.2.16, 10.3.8, 10.0.35-galera |
| Type: | Bug | Priority: | Critical |
| Reporter: | Daniel Black | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | contribution, foundation, galera, patch, sst | ||
| Description |
|
The sst script reads the mariadb-10.0 and mysql-10.0 section of the configuration file even in the 10.1+ versions of mariadb. trivial and lazy patch: https://github.com/MariaDB/server/compare/10.1...grooverdan:10.1-wsrep_sst_rsync_read_MYSQL_BASE_VERSION_config (I submit this under the MCA). Of course something like my_print_defaults --mysqld would be better. galera_recovery.sh also misses groups with version numbers by not using --mysqld. |
| Comments |
| Comment by Daniel Black [ 2018-01-13 ] |
|
Existing 4bb49d84a9df contains a wsrep_sst_rsync fix in 10.1 branch that wasn't carried forward. FYI - I've got a port of 4bb49d84a9df that includes --default-group-suffix (rework of 7d550c76be13c58551e203f4eeb4f87ebd58ba4b) capable sst scripts, targetted at 10.0-galera which would be good to carry forwards. PR coming soon. |
| Comment by Daniel Black [ 2018-01-14 ] |
|
https://github.com/MariaDB/server/pull/549 covers wsrep_sst_rsync bits and others against 10.0-galera target. PR #539 still relevent to galera_recovery.sh |
| Comment by Sergey Vojtovich [ 2018-03-13 ] |
|
Overdue PR. |