[MDEV-14330] Move tokudb*/mysqltest manpages to correct RPM Created: 2017-11-08  Updated: 2020-01-31  Resolved: 2020-01-28

Status: Closed
Project: MariaDB Server
Component/s: Documentation, Packaging, Platform RedHat, Server, Storage Engine - TokuDB
Affects Version/s: 10.2.10
Fix Version/s: 10.1.44, 10.2.31, 10.3.22, 10.4.12, 10.5.1

Type: Bug Priority: Major
Reporter: Michal Schorm Assignee: Vicențiu Ciorbaru
Resolution: Fixed Votes: 0
Labels: contribution, foundation
Environment:

Fedora - all


 Description   

I believe, those 2 manpages should be in tokudb subpackage, since without it they don't make sense:

  • tokuftdump.1.gz
  • tokuft_logdump.1.gz

This one's binary is in the test subpackage, but the manpage is in the server

  • mysqltest.1.gz

 Comments   
Comment by Michal Schorm [ 2018-06-29 ]

Also when built without tokudb (for example on non x86-64 arches), its manpages are still shipped, which is not correct.

This is from the Fedora SPECfile, where I remove them by hand:

%if %{without tokudb}
 
# because upstream ships manpages for tokudb even on architectures that tokudb doesn't support
 
rm %{buildroot}%{_mandir}/man1/tokuftdump.1*
 
rm %{buildroot}%{_mandir}/man1/tokuft_logdump.1*

Comment by Michal Schorm [ 2018-06-29 ]

btw I think theese files are also not used in any way.
If that's true, it would be good to remove them from the tarballs.

storage/tokudb/mysql-test/tokudb/t/*.py

Comment by Vicențiu Ciorbaru [ 2020-01-28 ]

mysqltest.1 man page move was fixed in 10.1
tokudb man pages were moved to storage/tokudb/man and are now part of tokudb-engine package, starting from 10.2

The .py files we will keep as it's part of the upstream repository. It is possible that TokuDB will be removed in later versions, hence they will stay there for now. A subsequent patch might remove them as install files, but the effort does not seem justified at this point.

Generated at Thu Feb 08 08:12:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.