[MDEV-14305] Add smoke sst test Created: 2017-11-07 Updated: 2021-05-13 Resolved: 2018-06-11 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera SST, Tests |
| Affects Version/s: | 10.1, 10.2 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Critical |
| Reporter: | Andrii Nikitin (Inactive) | Assignee: | Sergei Golubchik |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Sprint: | 10.2.11, 10.2.14 | ||||||||||||||||||||||||||||
| Description |
|
Current mtr sst tests are complicated with heavy dependencies and often skipped. |
| Comments |
| Comment by Andrii Nikitin (Inactive) [ 2017-11-07 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
suggested test for 10.2 sst_smoke.test
sst_smoke.combinations
With following patch:
While it is disabled (because of mtr limitations) it is still very useful to run it manually with --enable-disabled --nocheck-testcase It may need fixes for | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2017-11-14 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Andrii Nikitin (Inactive) [ 2017-11-14 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
1. The Idea for this mtr test was to be able to "just start Cluster with corresponding sst method". This is very useful at least for manual testing, because it is really time-consuming work to set up Cluster with other means. I guess current mtr approach for such cases is to startup cluster with unrelated configuration, then check prerequisites and change configuration to what needs to be tested. It is probably OK, but adds a lot of unrelated logs and may fail somewhere, which is not related to what actually needs to be tested. (And the main purpose of unit tests is to show where exactly failure is = the more unrelated code exists - the bigger chance that failure will happen in unrelated functionality and the more time is needed to troubleshoot failures). 2. mtr by default does db object verification, which interfere with cluster startup when sst´mysqldump is used (maybe this could be fixed as part of So my idea is to have this test just for friendly manual testing for now and later enable it if/when mtr is able to have configured --nocheck-testcase for individual tests and check prerequisites before starting servers. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2017-11-16 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
1. you can skip from suite.pm, if needed. we do it for, say, ipv6 tests where mysqld won't even start if ipv6 is not available. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Andrii Nikitin (Inactive) [ 2017-11-16 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Regarding 2. - I see following error before test starts , so galera will not allow any query from mtr check until sst is completed.
Maybe we can educate mtr later to re-try check_testcase for some time if error 1047 is received. Or maybe setting `session.WSREP_ON=0` from ./mtr will be sufficient? | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2018-06-11 ] | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
already done in |