[MDEV-14223] clang build failure in PerconaFT Created: 2017-10-30  Updated: 2018-04-10  Resolved: 2017-11-02

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Storage Engine - TokuDB
Affects Version/s: 10.0.33
Fix Version/s: 10.0.34

Type: Bug Priority: Major
Reporter: Bernard Spil Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: tokudb
Environment:

$ uname -a
FreeBSD build.example.org 11.1-RELEASE-p1 FreeBSD 11.1-RELEASE-p1 #0 r323352: Sat Sep 9 14:25:36 CEST 2017 build@build.example.org:/usr/obj/usr/src/sys/BEASTIE111 amd64
$ cc -v
FreeBSD clang version 4.0.0 (tags/RELEASE_400/final 297347) (based on LLVM 4.0.0)
Target: x86_64-unknown-freebsd11.1
Thread model: posix
InstalledDir: /usr/bin

Issue Links:
Relates
relates to MDEV-11965 -Werror should not appear in released... Closed
relates to MDEV-15778 Build issues on macOS 10.13.4 Closed

 Description   

clang error in storage/tokudb/PerconaFT/util/omt.cc

In file included from /usr/ports/databases/mariadb100-server/work/mariadb-10.0.33/storage/tokudb/PerconaFT/util/omt.h:759:
 
/usr/ports/databases/mariadb100-server/work/mariadb-10.0.33/storage/tokudb/PerconaFT/util/omt.cc:946:13: error: taking address of packed member 'value
 
' of class or structure 'toku::omt_internal::omt_node_templated<referenced_xid_tuple, false>' may result in an unaligned pointer value [-Werror,-Waddr
 
ess-of-packed-member]
 
    *out = &n->value;



 Comments   
Comment by Sergei Golubchik [ 2017-11-01 ]

Ugh, I thought MDEV-11965 has fixed it, but apparently it was pushed only in 10.1+

Comment by Vesa Pentti (Inactive) [ 2017-11-01 ]

Backporting 2a0ae1c90acc6332606144719764cb5fc730bf3b makes it work. Shall I push directly to 10.0 ?

Comment by Sergei Golubchik [ 2017-11-01 ]

yes, please

Comment by Vesa Pentti (Inactive) [ 2017-11-02 ]

Done

Generated at Thu Feb 08 08:11:53 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.