[MDEV-14035] Unknown system variable 'debug_dbug' in sst/ist galera tests Created: 2017-10-10  Updated: 2018-06-11  Resolved: 2018-06-11

Status: Closed
Project: MariaDB Server
Component/s: Galera SST, Tests
Affects Version/s: 10.1.28
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Andrii Nikitin (Inactive) Assignee: Sergei Golubchik
Resolution: Won't Fix Votes: 0
Labels: None

Attachments: File MDEV-14035.diff    
Issue Links:
Relates
relates to MDEV-14030 Remove or Merge wsrep_sst_mariabackup Closed

 Description    

CURRENT_TEST: galera.galera_sst_xtrabackup-v2
 
mysqltest: In included file "./suite/galera/include/galera_st_kill_slave_ddl.inc": 
included from /home/a/e1/m1-10.1/src/mysql-test/suite/galera/t/galera_sst_xtrabackup-v2.test at line 15:
 
At line 24: query 'let $debug_orig = `SELECT @@debug_dbug`' failed: 1193: Unknown system variable 'debug_dbug'


$ grep -r debug_dbug * | grep -v .result
 
include/galera_st_kill_slave_ddl.inc:--let $debug_orig = `SELECT @@debug_dbug`
 
include/galera_st_kill_slave_ddl.inc:SET GLOBAL debug_dbug = 'd,sync.alter_opened_table';
 
include/galera_st_kill_slave_ddl.inc:SET GLOBAL debug_dbug = $debug_orig;
 
$ grep -r galera_st_kill_slave_ddl.inc
 
t/galera_ist_mysqldump.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_ist_xtrabackup-v2.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_sst_rsync.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_sst_mysqldump.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_ist_rsync.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_sst_xtrabackup-v2.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc
 
t/galera_ist_innodb_flush_logs.test:--source suite/galera/include/galera_st_kill_slave_ddl.inc



 Comments   
Comment by Elena Stepanova [ 2017-10-10 ]

Tests which use debug_dbug (or other debug-only variables) should have --source include/have_debug.inc.

Comment by Andrii Nikitin (Inactive) [ 2017-10-10 ]

Thank you, I know about have_debug.inc , just wanted non-debug functionality from those tests to be tested in release builds.
Proper solution for the problem should be rewriting galera_st_kill_slave.inc and galera_st_kill_slave_ddl.inc into tests which run in combinations for every sst / ist method. Then it will be possible to run debug-requiring functionality test only in debug builds, still having proper coverage for release builds

Comment by Andrii Nikitin (Inactive) [ 2017-10-14 ]

Suggested patch is in attached MDEV-14035.diff . mysqldump sst method is commented out because original test doesn't work at the moment and needs fix ( MDEV-14069 )

Comment by Andrii Nikitin (Inactive) [ 2017-10-23 ]

The main ideas behind patch:
Currently we have very similar tests e.g. galera_sst_rsync and galera_sst_xtrabackup-v2
Those tests do set of internal checks. And one of those checks may be performed only in debug, thus the rest checks cannot run in release at the moment as well (because of mtr limitations)
Plus need to create one more copy of those tests for mariabackup sst method

Suggested approach uses single test, which is performed for combinations of those checks for each sst method.
The check which requires debug build is skipped in Release builds and all others are performed properly, including smoke SST test (i.e. no real load and no --big-test flag) and mariabackup combination

Comment by Sergei Golubchik [ 2018-06-11 ]

Already fixed using maybe_debug.inc

Generated at Thu Feb 08 08:10:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.