[MDEV-14030] Remove or Merge wsrep_sst_mariabackup Created: 2017-10-09 Updated: 2018-11-05 Resolved: 2018-06-11 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera SST, Tests |
| Affects Version/s: | 10.1, 10.2 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Andrii Nikitin (Inactive) | Assignee: | Sergei Golubchik |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
wsrep_sst_mariabackup is quite different from wsrep_sst_xtrabackup-v2 , and I believe it is just merge issue, where wsrep_sst_xtrabackup-v2 got latest commits, while wsrep_sst_mariabackup haven't We need either delete wsrep_sst_mariabackup (and make sure that wsrep_sst_xtrabackup-v2 works with mariabackup) or change both scripts the way that wsrep_sst_mariabackup reuses wsrep_sst_xtrabackup-v2 , just redefining INNOBACKUPEX_BIN and XBSTREAM_BIN , etc |
| Comments |
| Comment by Andrii Nikitin (Inactive) [ 2017-10-13 ] | ||||||||||
|
Suggested patch is in attached diff.txt wsrep_sst_mariabackup is suggested to be just wrapper around wsrep_sst_xtrabackup-v2 , (which requires few changes to wsrep_sst_xtrabackup-v2)
It has new test sst_smoke , which does simple sst attempt (only with rsync and mariabackup at the moment, needs mysqldump to be added after proper fix in | ||||||||||
| Comment by Andrii Nikitin (Inactive) [ 2017-10-14 ] | ||||||||||
|
| ||||||||||
| Comment by Sergei Golubchik [ 2018-06-11 ] | ||||||||||
|
as far as tests are concerned, both galera_sst_xtrabackup-v2 and galera_sst_mariabackup tests were fixed to pass, there's no need to merge them. |