[MDEV-14030] Remove or Merge wsrep_sst_mariabackup Created: 2017-10-09  Updated: 2018-11-05  Resolved: 2018-06-11

Status: Closed
Project: MariaDB Server
Component/s: Galera SST, Tests
Affects Version/s: 10.1, 10.2
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Andrii Nikitin (Inactive) Assignee: Sergei Golubchik
Resolution: Won't Fix Votes: 0
Labels: None

Attachments: Text File diff.txt    
Issue Links:
Blocks
blocks MDEV-13789 mariabackup galera SST fail Closed
Relates
relates to MDEV-13968 sst fails with "WSREP_SST_OPT_PORT: r... Closed
relates to MDEV-13969 sst mysqldump and xtrabackup-v2 handl... Closed
relates to MDEV-14034 test galera_sst_xtrabackup-v2 fails w... Closed
relates to MDEV-14256 MariaDB 10.2.10 can't SST with xtraba... Closed
relates to MDEV-11964 [Docs] RPM Lint: no-manual-page-for-b... Open
relates to MDEV-14035 Unknown system variable 'debug_dbug' ... Closed
relates to MDEV-14612 Galera SST xtrabackup-v2/mariabackup ... Closed
relates to MDEV-17618 Galera SST IPv6 problems Closed

 Description   

wsrep_sst_mariabackup is quite different from wsrep_sst_xtrabackup-v2 , and I believe it is just merge issue, where wsrep_sst_xtrabackup-v2 got latest commits, while wsrep_sst_mariabackup haven't

We need either delete wsrep_sst_mariabackup (and make sure that wsrep_sst_xtrabackup-v2 works with mariabackup) or change both scripts the way that wsrep_sst_mariabackup reuses wsrep_sst_xtrabackup-v2 , just redefining INNOBACKUPEX_BIN and XBSTREAM_BIN , etc



 Comments   
Comment by Andrii Nikitin (Inactive) [ 2017-10-13 ]

Suggested patch is in attached diff.txt

wsrep_sst_mariabackup is suggested to be just wrapper around wsrep_sst_xtrabackup-v2 , (which requires few changes to wsrep_sst_xtrabackup-v2)

 
function innobackupex() {
  mariabackup --innobackupex "$@"
}
 
function xbstream() {
  mbstream "$@"
}
 
. "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/wsrep_sst_xtrabackup-v2

It has new test sst_smoke , which does simple sst attempt (only with rsync and mariabackup at the moment, needs mysqldump to be added after proper fix in MDEV-13968 and MDEV-13969). (Because current sst tests are huge and require --big-test and work only in debug build)
It has some patches addressed to hide problems in MDEV-13968 and MDEV-13969, so will conflict with commits from them - but needs them to make sure that new test does work properly.

Comment by Andrii Nikitin (Inactive) [ 2017-10-14 ]

Actually proposed here sst_smoke test will not be needed if patch from MDEV-14035 is approved, which introduces smoke sst together with more complex combinations for each sst
EDIT: It is still better to add proposed sst_smoke, because sst_mysqldump in MDEV-14035 uses some complicated configuration with redefining receive_address, etc and starts with rsync, then changes to mysqldump method dynamically, etc.
And this test doesn't have any non-default option (no .cnf file)

Comment by Sergei Golubchik [ 2018-06-11 ]

as far as tests are concerned, both galera_sst_xtrabackup-v2 and galera_sst_mariabackup tests were fixed to pass, there's no need to merge them.

Generated at Thu Feb 08 08:10:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.