[MDEV-14010] merge issue in wsrep_sst_xtrabackup-v2 Created: 2017-10-05  Updated: 2017-11-06  Resolved: 2017-10-09

Status: Closed
Project: MariaDB Server
Component/s: Galera SST
Affects Version/s: 10.1.28, 10.2.9
Fix Version/s: 10.1.29

Type: Bug Priority: Critical
Reporter: Andrii Nikitin (Inactive) Assignee: Andrii Nikitin (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-9436 When using xtrabackup-v2 SST, built-i... Closed
relates to MDEV-10934 SST fails when SSL is enabled Closed

 Description   

This line really shouldn't belong where it is:

https://github.com/MariaDB/server/blob/mariadb-10.1.28/scripts/wsrep_sst_xtrabackup-v2.sh#L361
https://github.com/MariaDB/server/blob/mariadb-10.2.9/scripts/wsrep_sst_xtrabackup-v2.sh#L361

This was spotted during troubleshooting of MDEV-10934 , and after patch below the error gone:

--- /home/a/mariadb-environs/_depot/m-tar/10.1.28/bin/wsrep_sst_xtrabackup-v2	2017-09-27 14:30:44.000000000 +0200
+++ _depot/m-tar/10.1.28/bin/wsrep_sst_xtrabackup-v2	2017-10-05 14:33:09.891682811 +0200
@@ -358,8 +358,7 @@
             if [[ "$WSREP_SST_OPT_ROLE"  == "joiner" ]];then
                 wsrep_log_info "Decrypting with CERT: $tcert, KEY: $tkey"
                 tcmd="socat -u openssl-listen:${TSST_PORT},reuseaddr,cert=${tcert},key=${tkey},verify=0${joiner_extra}${sockopt} stdio"
-                    tcmd="socat -u openssl-listen:${TSST_PORT},reuseaddr,cert=${tpem},key=${tkey},verify=0${sockopt} stdio"
-                else
+            else
                 wsrep_log_info "Encrypting with CERT: $tcert, KEY: $tkey"
                 tcmd="socat -u stdio openssl-connect:${REMOTEIP}:${TSST_PORT},cert=${tcert},key=${tkey},verify=0${sockopt}"
             fi

Note that variable `tpem` used in removed line - isn't really referenced anywhere else in the script.


Generated at Thu Feb 08 08:10:12 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.