[MDEV-13961] mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/proc.c:4515:8: warning: this statement may fall through Created: 2017-09-29  Updated: 2023-05-23  Resolved: 2023-05-23

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2.9
Fix Version/s: N/A

Type: Bug Priority: Minor
Reporter: David Binderman Assignee: Nayuta Yanagisawa (Inactive)
Resolution: Won't Fix Votes: 0
Labels: cppcheck


 Description   

Source code is

  switch (type) {
 
  case GRN_DB_UINT8 :
 
    if (is_negative_value(src)) {
 
      GRN_UINT8_SET(ctx, dest, 0);
 
      return GRN_TRUE;
 
    }
 
  case GRN_DB_UINT16 :
 
    if (is_negative_value(src)) {
 
      GRN_UINT16_SET(ctx, dest, 0);
 
      return GRN_TRUE;
 
    }

Suggest add missing break statements throughout this switch statement.

 Comments   
Comment by Yuchen Pei [ 2023-05-23 ]

Closing because 10.2 was EOL

Generated at Thu Feb 08 08:09:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.