[MDEV-13956] mariadb-10.2.9/libmariadb/plugins/pvio/pvio_socket.c:817: strange expression ? Created: 2017-09-29  Updated: 2017-09-30  Resolved: 2017-09-30

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2.9
Fix Version/s: 10.2.10

Type: Bug Priority: Critical
Reporter: David Binderman Assignee: Georg Richter
Resolution: Fixed Votes: 0
Labels: cppcheck


 Description    

mariadb-10.2.9/libmariadb/plugins/pvio/pvio_socket.c:817]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

    while ((gai_rc= getaddrinfo(cinfo->host, server_port,
 
                                &hints, &res) == EAI_AGAIN))

Maybe better code

    while ((gai_rc= getaddrinfo(cinfo->host, server_port,
 
                                &hints, &res)) == EAI_AGAIN)


Generated at Thu Feb 08 08:09:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.