[MDEV-13954] mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/egn.cpp: 2 * suspicious condition ? Created: 2017-09-29  Updated: 2022-05-09

Status: Open
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2.9
Fix Version/s: 10.2

Type: Bug Priority: Minor
Reporter: David Binderman Assignee: Kouhei Sutou
Resolution: Unresolved Votes: 0
Labels: cppcheck


 Description    

[mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/egn.cpp:2731] -> [mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/egn.cpp:2731]: (style) Same expression on both sides of '||'.
 
[mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/egn.cpp:2738] -> [mariadb-10.2.9/storage/mroonga/vendor/groonga/lib/egn.cpp:2738]: (style) Same expression on both sides of '||'.

Source code is

      if ((arg1->data_type() != GRN_DB_BOOL) ||
 
          (arg1->data_type() != GRN_DB_BOOL)) {

Similar code a few lines further down.

      if ((arg1->data_type() != GRN_DB_BOOL) ||
 
          (arg1->data_type() != GRN_DB_BOOL)) {



 Comments   
Comment by Kouhei Sutou [ 2022-05-09 ]

The latest Groonga doesn't have the code. So we can close this when we done MDEV-20544.

Generated at Thu Feb 08 08:09:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.