[MDEV-13856] Incorrect error message for ALTER TABLE t1 ENCRYPTED=YES, ALGORITHM=INPLACE Created: 2017-09-20  Updated: 2023-04-12  Resolved: 2023-04-11

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB, Storage Engine - XtraDB
Affects Version/s: 10.1
Fix Version/s: N/A

Type: Bug Priority: Minor
Reporter: Jan Lindström (Inactive) Assignee: Jan Lindström (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None


 Description    

ALTER TABLE t1 ENCRYPTED=YES, FORCE, ALGORITHM=INPLACE;
 
ERROR 0A000: ALGORITHM=INPLACE is not supported. Reason: %s is not supported. Reason: %s. Try %s.. Try ALGORITHM=COPY.



 Comments   
Comment by Jan Lindström (Inactive) [ 2017-09-20 ]

https://github.com/MariaDB/server/commit/4fd87a9a204a86e2c22b337ee160cf093f9c9f69

Comment by Marko Mäkelä [ 2017-09-21 ]

jplindst, please change the bug title. The problem is that ALGORITHM=INPLACE is refused in the first place; not the error message of the refusal.

Also, why do we care about atomic_writes mismatch? It is not changing the file format at all.

ALGORITHM=INPLACE can rebuild a table perfectly fine if the ROW_FORMAT is changed. Why should other file format attributes be different?

(Yes, the name ‘inplace’ is unfortunate and misleading; a table rebuild can hardly be considered an in-place operation. I hope some day MDEV-13134 will fix that.)

Please submit a fix that modifies innobase_need_rebuild() so that a rebuild will be initiated if file format attributes are changed.

Comment by Jan Lindström [ 2023-04-11 ]

10.1 is EOL.

Generated at Thu Feb 08 08:08:55 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.