[MDEV-13630] storage/connect/CMakeLists.txt builds and installs jars files, even if engine is not built Created: 2017-08-23  Updated: 2017-08-31  Resolved: 2017-08-24

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Connect
Affects Version/s: None
Fix Version/s: 10.0.33, 10.1.27, 10.2.9, 10.3.2

Type: Bug Priority: Major
Reporter: Vladislav Vaintroub Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None


 Description   

If Java and JNI are found, following code is executed in connect/CMakeLists.txt

   add_jar(JdbcInterface ${JAVA_SOURCES})
    INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/JavaWrappers.jar
      ${CMAKE_CURRENT_BINARY_DIR}/JdbcInterface.jar
DESTINATION ${INSTALL_PLUGINDIR} COMPONENT connect-engine)

This happens unconditionally also if the connect engine is NOT build.
A good style that helps to avoid these kinds of problems is to do MYSQL_ADD_PLUGIN early and do RETURN() if plugin is not built


Generated at Thu Feb 08 08:07:06 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.