[MDEV-13583] Improvements for MTR rebootstrap introduced in MDEV-12042 Created: 2017-08-18 Updated: 2017-08-31 Resolved: 2017-08-28 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 10.0, 10.1, 10.2 |
| Fix Version/s: | 10.0.33, 10.1.27, 10.2.9 |
| Type: | Bug | Priority: | Major |
| Reporter: | Elena Stepanova | Assignee: | Elena Stepanova |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Change in MTR made in scope of
There are some problems to fix and things to improve. 1. Re-bootstrap with inconsistent set of optionsThe above logic does not work well enough when InnoDB options depend on other server settings. For example, if we run
we'll get
This is because rebootstrap here doesn't actually work. It attempts to start with innodb options which require encryption, but without the encryption plugin itself, because it only chooses InnoDB options from $extra_opts, while plugin-load-add is ignored; so InnoDB doesn't start at all, and hence the tables and log files don't get created upon bootstrap.
2. Re-creating bootstrap.sql upon re-bootstrapEvery time re-bootstrap is issued, it re-creates bootstrap.sql file from scratch. It shouldn't take that much resources, but it is unnecessary; besides, we are having troubles on Windows, where tests sometimes fail upon re-bootsrap apparently because the bootstrap.sql file is locked when they want to re-create it. While we don't know root cause of the problem, it might well go away if we just stop re-creating it when it already exists. One catch is that currently it's located in var/tmp, which is removed between the tests; but we can store it in var/log instead, it might even be beneficial to keep it after test run when we want to analyze some obscure bootstrap problems. 3. Bootstrap log on WindowsNot directly related to |
| Comments |
| Comment by Elena Stepanova [ 2017-08-28 ] |
|
https://github.com/MariaDB/server/commit/05e7d35e898a1827464627ebfb815f4707ac6ac1 |