[MDEV-13539] Latest revision of bb-10.3-svoj (big column compressed) does not compile Created: 2017-08-15  Updated: 2017-08-16  Resolved: 2017-08-16

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: N/A
Fix Version/s: N/A

Type: Bug Priority: Blocker
Reporter: Elena Stepanova Assignee: Sergey Vojtovich
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-13342 Testing for MDEV-11371 (Big column co... Closed
Relates
relates to MDEV-11371 Big column compressed Closed

 Description   

http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-trusty-amd64/builds/2168/steps/compile/logs/stdio

In file included from /home/buildbot/buildbot/build/client/mysqlbinlog.cc:3115:0:
/home/buildbot/buildbot/build/sql/rpl_utility.cc: In member function 'uint32 table_def::calc_field_size(uint, uchar*) const':
/home/buildbot/buildbot/build/sql/rpl_utility.cc:299:8: error: 'MYSQL_TYPE_VARCHAR_COMPRESSED' was not declared in this scope
   case MYSQL_TYPE_VARCHAR_COMPRESSED:
        ^
/home/buildbot/buildbot/build/sql/rpl_utility.cc:309:8: error: 'MYSQL_TYPE_BLOB_COMPRESSED' was not declared in this scope
   case MYSQL_TYPE_BLOB_COMPRESSED:
        ^
/home/buildbot/buildbot/build/sql/rpl_utility.cc: In constructor 'table_def::table_def(unsigned char*, ulong, uchar*, int, uchar*, uint16)':
/home/buildbot/buildbot/build/sql/rpl_utility.cc:1074:12: error: 'MYSQL_TYPE_BLOB_COMPRESSED' was not declared in this scope
       case MYSQL_TYPE_BLOB_COMPRESSED:
            ^
/home/buildbot/buildbot/build/sql/rpl_utility.cc:1105:12: error: 'MYSQL_TYPE_VARCHAR_COMPRESSED' was not declared in this scope
       case MYSQL_TYPE_VARCHAR_COMPRESSED:
            ^



 Comments   
Comment by Sergey Vojtovich [ 2017-08-16 ]

I explained this in a comment to MDEV-13342. I don't want to patch libmariadb yet, before this task is finally approved.

To make it work currently, libmariadb has to be patched:

diff --git a/include/mariadb_com.h b/include/mariadb_com.h
index cdf7db8..31550cb 100644
--- a/include/mariadb_com.h
+++ b/include/mariadb_com.h
@@ -327,6 +327,8 @@ enum enum_field_types { MYSQL_TYPE_DECIMAL, MYSQL_TYPE_TINY,
                         MYSQL_TYPE_TIMESTAMP2,
                         MYSQL_TYPE_DATETIME2,
                         MYSQL_TYPE_TIME2,
+                        MYSQL_TYPE_BLOB_COMPRESSED= 140,
+                        MYSQL_TYPE_VARCHAR_COMPRESSED= 141,
                         /* --------------------------------------------- */
                         MYSQL_TYPE_JSON=245,
                         MYSQL_TYPE_NEWDECIMAL=246,

Comment by Elena Stepanova [ 2017-08-16 ]

We can patch it locally for testing. The problem is, it doesn't build in buildbot at all, so it doesn't undergo regression tests. It's a catch 22, you can't merge it to the main tree until buildbot confirms it's in a decent shape, and buildbot can't confirm it's in a decent shape because the relevant page hasn't pushed to the submodule's tree.

According to serg, you should be able to create a development branch for libmariadb and use it instead.

Comment by Sergey Vojtovich [ 2017-08-16 ]

Fixed in bb-10.3-svoj.

Generated at Thu Feb 08 08:06:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.