[MDEV-13033] inconsistent inclusion of spider engine between centos and ubuntu Created: 2017-06-07 Updated: 2021-08-16 |
|
| Status: | Stalled |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Affects Version/s: | 10.2.6, 10.3, 10.4 |
| Fix Version/s: | 10.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | David Thompson (Inactive) | Assignee: | Otto Kekäläinen |
| Resolution: | Unresolved | Votes: | 1 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
If i use the package install guide on mariadb.org then for centos7, the spider engine is installed as part of the yum install. However for ubuntu xenial it is not and must be installed seperately using: We should be consistent between platforms. I have not tested other platforms but i'd take a guess debian will behave the same as ubuntu. At least the following files should exist: |
| Comments |
| Comment by Sergei Golubchik [ 2020-05-05 ] |
|
In the RPM packages we define what plugin has to be packaged separately using a clear rule — if plugin has dependencies (from the package manager point of view) that the server doesn't then the plugin must go into its own package. Spider does not add dependencies to the server rpm, that's why it's packaged into the server rpm. In the DEB packages we follow the downstream, what Debian does. I don't know what rules debian packaging has. otto, why mariadb-plugin-spider is a separate package? |
| Comment by Otto Kekäläinen [ 2020-05-17 ] |
|
Spider (among others) was split to its own package in d495bf42807c301da579e5de2ffcb39ea73df928. Having it as a separate package makes it easier to comply in Debian that the same package should have the same contents on each platform. When plugins like TokuDB, Spider, RocksDB etc fail to build on all platforms it is easier to selectively skip the whole package on a particular arch. This way it is clear to users which arch the plugin is available and where not, and also all testing and CI systems work more nicely when one can define explicitly that certains plugins (packages) are available only on certains archs. Also having them as separate packages makes it a nicer user experience when users can install and activate storage engines with simply running 'apt install mariadb-plugin-spider', although this latter thing is just a minor feat. |
| Comment by Sergei Golubchik [ 2020-05-18 ] |
|
Okay, so Debian rule is "same package should have the same contents on each platform". I see how it applies to TokuDB and RocksDB, but Spider is always built unconditionally on all platforms, so this apparently doesn't apply to it. It's only disabled on Travis. |
| Comment by Sergei Golubchik [ 2020-06-22 ] |
|
So, otto, I believe that Spider should be moved back into the server package. It'll be in compliance with Debian policy that the package content should be the same on all platforms, and it'll be consistent with how we package Spider for other distributions. Agree? |
| Comment by Otto Kekäläinen [ 2020-06-26 ] |
|
WIP at https://github.com/MariaDB/server/pull/1608 for Serg's request above. |
| Comment by Nayuta Yanagisawa (Inactive) [ 2021-08-13 ] |
|
Hi otto! I'm Nayuta Yanagisawa, a new Spider developer. Do you have any plans to resume this task? |
| Comment by Otto Kekäläinen [ 2021-08-16 ] |
|
Hello and welcome nayuta-yanagisawa! I refreshed the PR at https://github.com/MariaDB/server/pull/1608 now, but it needs more testing and should target 10.7 instead of old 10.5. |
| Comment by Nayuta Yanagisawa (Inactive) [ 2021-08-16 ] |
|
Hi! Thank you for sharing the status. It would be helpful if you could proceed when you have time. |