[MDEV-12864] aws_key_management shouldn't generate user warnings Created: 2017-05-22  Updated: 2017-08-30  Resolved: 2017-08-30

Status: Closed
Project: MariaDB Server
Component/s: Plugin - AWS key management
Affects Version/s: 10.1.23
Fix Version/s: N/A

Type: Bug Priority: Minor
Reporter: Andrii Nikitin (Inactive) Assignee: Vladislav Vaintroub
Resolution: Not a Bug Votes: 0
Labels: None


 Description   

Encryption management messages shouldn't be exposed to Users who execute SQL commands.

MariaDB [test]> create table test.t1(a int) encryption_key_id=2;
Query OK, 0 rows affected, 2 warnings (1.44 sec)
MariaDB [test]> show warnings;
+-------+------+---------------------------------------------------------------------+
| Level | Code | Message                                                             |
+-------+------+---------------------------------------------------------------------+
| Note  | 1105 | AWS KMS plugin: generated encrypted datakey for key id=2, version=1 |
| Note  | 1105 | AWS KMS plugin: loaded key 2, version 1, key length 128 bit         |
+-------+------+---------------------------------------------------------------------+
2 rows in set (0.00 sec)

Another example:

MariaDB [(none)]> select * from test.t1;
Empty set, 1 warning (0.28 sec)
 
MariaDB [(none)]> show warnings;
+-------+------+-------------------------------------------------------------+
| Level | Code | Message                                                     |
+-------+------+-------------------------------------------------------------+
| Note  | 1105 | AWS KMS plugin: loaded key 2, version 1, key length 128 bit |
+-------+------+-------------------------------------------------------------+
1 row in set (0.00 sec



 Comments   
Comment by Vladislav Vaintroub [ 2017-08-29 ]

serg, do you think anything needs to be done here?
it is there since my_printf_error(.. ME_NOTE), previously it was only in error log, written with sql_print_information.

anikitin, there is sql_notes variable that is supposed to silence the Notes (i.e non-warnings) exposed as warnings.

Comment by Sergei Golubchik [ 2017-08-30 ]

I don't think there's anything to do here. Notes are purely informational, this is information. They can be suppressed, if desired.

Generated at Thu Feb 08 08:01:04 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.