[MDEV-12645] mysql_install_db: no install test db option Created: 2017-04-30 Updated: 2020-09-12 Resolved: 2018-04-30 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Packaging, Scripts & Clients |
| Fix Version/s: | 10.3.7 |
| Type: | Task | Priority: | Major |
| Reporter: | Daniel Black | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | contribution, foundation | ||
| Issue Links: |
|
||||||||
| Description |
|
Neither Red Hat, Fedora or Debian want to install a test database with mysql_install_db ref: https://github.com/devexp-db/mariadb/blob/f27/mariadb-notestdb.patch As distros are the big users of mysql_install_db an one of these patches be merged upstream or an option provided to mysql_install_db? |
| Comments |
| Comment by Sergei Golubchik [ 2017-04-30 ] |
|
I'd add an option. The usual semantics, --test-db to add it, --skip-test-db not to. And the default to add it in bintars and not to add it in DEB/RPM. |
| Comment by Michal Schorm [ 2017-04-30 ] |
|
That sound's like the best possible solution for me. |
| Comment by Daniel Black [ 2017-12-28 ] |
|
PR contains two patches for this as per serg's spec above. mschorm mysql_install_db --skip-auth-anonymous-user is probably something you also want. |
| Comment by Daniel Black [ 2018-03-13 ] |
|
Overdue PR. |
| Comment by Sergey Vojtovich [ 2018-04-11 ] |
|
serg, please review https://github.com/MariaDB/server/commit/b2162ed41438908b23f6083a3089063d1fbffb0c |
| Comment by Sergey Vojtovich [ 2018-04-12 ] |
|
serg, now it is https://github.com/MariaDB/server/commit/7aa4f2f323bfaad675102f84e72103b83b4d54bd (with test fixes). |
| Comment by Sergey Vojtovich [ 2018-04-13 ] |
|
Yet more tests fixed in https://github.com/MariaDB/server/commit/74e43e5d54a684312f47d4db9daf209575accfdb |
| Comment by Sergey Vojtovich [ 2018-04-13 ] |
|
Now 9ed1b9d659af4f955ad4994104aba32be95ee950 with mysql_install_db.exe fixed (thanks to wlad). |
| Comment by Daniel Black [ 2018-04-14 ] |
|
debian/mariadb-server-10.3.postinst needs --skip-auth-anonymous-user to fully remove debian/patches/33_scripts_mysql_create_system_tables_no_test.dpatch so RPMs also have a consistent install add --skip-auth-anonymous-user and --skip-test-db to the mysql_install_db in ./support-files/rpm/server-postin.sh Didn't realise so many tests depended on a "clean" directory. Thanks for cleaning those up and the Windows mysql_install_db.cc. |
| Comment by Sergey Vojtovich [ 2018-04-25 ] |
|
Anonymous user without test db doesn't seem to make any sense. I removed this option and moved anonymous user creation to mysql_test_db.sql. Patches are in bb-10.3-svoj. |
| Comment by Sergei Golubchik [ 2018-04-26 ] |
|
looks ok to me |