[MDEV-12615] InnoDB page compression method snappy mostly does not compress pages Created: 2017-04-28 Updated: 2020-08-12 Resolved: 2017-05-20 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB, Storage Engine - XtraDB |
| Affects Version/s: | 10.1 |
| Fix Version/s: | 10.1.24 |
| Type: | Bug | Priority: | Major |
| Reporter: | Jan Lindström (Inactive) | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 10.1.24 |
| Description |
|
Test innodb-page_compression_snappy should make sure that table is really compressed in storage. Furthermore, snappy requires extra memory space to really compress a buffer. |
| Comments |
| Comment by Jan Lindström (Inactive) [ 2017-04-28 ] |
|
https://github.com/MariaDB/server/commit/d390aad50ba82ae1dbabbfff044f0042ef9dc475 |
| Comment by Marko Mäkelä [ 2017-05-05 ] |
|
Please address my review comments. |
| Comment by Jan Lindström (Inactive) [ 2017-05-20 ] |
|
commit 90c52e5291b3ad0935df7da56ec0fcbf530733b4 Snappy compression method require that output buffer buf_tmp_buffer_t: removed unnecessary lzo_mem, crypt_buf_free and buf_pool_reserve_tmp_slot: use alligned_alloc and if snappy fil_compress_page: Remove unneeded lzo mem (we use same buffer) Decompression does not require additional work area. Modify test to use same test as other compression method tests. |