[MDEV-12472] InnoDB should accept XtraDB parameters, warning that they are ignored Created: 2017-04-07 Updated: 2020-08-10 Resolved: 2017-05-09 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Fix Version/s: | 10.2.6 |
| Type: | Task | Priority: | Blocker |
| Reporter: | Marko Mäkelä | Assignee: | Oleksandr Byelkin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 10.2-ga, portability, upgrade, xtradb | ||
| Issue Links: |
|
||||||||||||
| Description |
|
MariaDB Server 10.2 will not ship with Percona XtraDB at all, but only with Oracle InnoDB.
Some discretion could be used. The innodb_api* settings never did anything useful in MariaDB, and they were removed in innodb_additional_mem_pool_size and innodb_use_sys_malloc can be removed, because they were deprecated in Oracle MySQL 5.6 (thus, MariaDB 10.0 already) and removed in 5.7. innodb_adaptive_hash_index_partitions was implemented in MySQL 5.7 as innodb_adaptive_hash_index_parts. We should have an alias for that. The Percona setting innodb_log_checksum_algorithm (a choice of values) was replaced by the Boolean innodb_log_checksums (offering CRC-32C or none). We could map the value "none" to OFF and everything else to ON. The remaining parameters look like Percona additions which we can choose to ignore (issuing a warning). Perhaps some features could be ported from Percona 5.7. |
| Comments |
| Comment by Jan Lindström (Inactive) [ 2017-05-05 ] |
|
https://github.com/MariaDB/server/commit/b297b310f236117425b3de3992ad853d2ec52db5 |
| Comment by Jan Lindström (Inactive) [ 2017-05-05 ] |
|
bb-10.2- |
| Comment by Oleksandr Byelkin [ 2017-05-09 ] |
|
stats_include_delete_marked looks like defined in innodb |
| Comment by Oleksandr Byelkin [ 2017-05-09 ] |
|
commit c54111aec91e6b894cb8ebdf9827e792ecebc831 tests and fixes commit b297b310f236117425b3de3992ad853d2ec52db5 Added a new file ha_xtradb.h where XtraDB parameters are defined. This innodb_show_locks_held and innodb_show_verbose_locks should be |
| Comment by Oleksandr Byelkin [ 2017-05-09 ] |
|
github branch bb-10.2- |
| Comment by Jan Lindström (Inactive) [ 2017-05-09 ] |
|
Can you remove unnecessary use-sys-malloc parameter and see from bb that this compiles also on Windows and product build. ok to push after that. |
| Comment by Marko Mäkelä [ 2020-08-10 ] |
|
For the record, these compatibility parameters were intentionally omitted from MariaDB Server 10.3 and later releases. If they had not been, they should have been removed from MariaDB Server 10.6 in |