[MDEV-12470] 'make test' failing Created: 2017-04-07 Updated: 2021-06-05 Resolved: 2017-04-07 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 10.2.5 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Michal Schorm | Assignee: | Sergei Golubchik |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Fedora 25 - GCC 6 |
||
| Issue Links: |
|
||||||||||||
| Description |
|
Hello,
Full build log can be found here. |
| Comments |
| Comment by Sergei Golubchik [ 2017-04-07 ] |
|
Connector/C unit tests require a running server, they cannot be run standalone. We use mysql-test-run for that, it sets up the environment, starts the server, and then runs C/C unit tests. See, for example this build log, C/C tests start from "unit.conc_" I understand that your problem is that make test fails, right? We could make C/C tests to be skipped, if the server isn't running, but that creates a danger of everything looking good in mysql-test, even when it's not. In fact, that's exactly what we had earlier, C/C tests "passed" perfectly, because they silently returned 0 if the server wasn't found. |
| Comment by Michal Schorm [ 2017-04-07 ] |
|
Ok
In Fedora, we have both 'make test' and the 'mysql-test.run'. |
| Comment by Sergei Golubchik [ 2017-04-07 ] |
|
No, not 10.1. Earlier releases of 10.2. We've replaced libmysqlclient with libmariadb in 10.2, libmariadb came with unit tests, mysql-test-run picked them up, they all passed, all was fine. And then we've realized that they "pass" because they return 0 (which means success) when they cannot connect to the server. After this was fixed, tests were not all passing anymore |