[MDEV-12431] MariaRocks unittest does not compile Created: 2017-04-03  Updated: 2018-04-10

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Affects Version/s: N/A
Fix Version/s: 10.4

Type: Bug Priority: Minor
Reporter: Sergei Petrunia Assignee: Sergei Petrunia
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
PartOf
is part of MDEV-9658 Make MyRocks in MariaDB stable Closed

 Description   

There is a unit test in storage/rocksdb/unittests/test_properties_collector.cc .

It was developed when the server was linked statically.
It was not compiled after switching to ha_rocksdb.so build.
An attempt to enable its compilation 44bc2a0ef71b034a0efea13cde96033743a69651 caused a compile error:

CMakeFiles/test_properties_collector.dir/test_properties_collector.cc.o: In function `rocksdb::Status::Status(rocksdb::Status::Code, rocksdb::Slice const&, rocksdb::Slice const&)':
/home/ubuntu/mariadb-10.2-comp2/storage/rocksdb/rocksdb/include/rocksdb/status.h:248: undefined reference to `rocksdb::Status::Status(rocksdb::Status::Code, rocksdb::Status::SubCode, rocksdb::Slice const&, rocksdb::Slice const&)'
/home/ubuntu/mariadb-10.2-comp2/storage/rocksdb/rocksdb/include/rocksdb/status.h:248: undefined reference to `rocksdb::Status::Status(rocksdb::Status::Code, rocksdb::Status::SubCode, rocksdb::Slice const&, rocksdb::Slice const&)'
CMakeFiles/test_properties_collector.dir/test_properties_collector.cc.o: In function `main':
/home/ubuntu/mariadb-10.2-comp2/storage/rocksdb/unittest/test_properties_collector.cc:41: undefined reference to `myrocks::Rdb_tbl_prop_coll::Rdb_tbl_prop_coll(myrocks::Rdb_ddl_manager*, myrocks::Rdb_compact_params const&, unsigned int const&, unsigned char const&)'
CMakeFiles/test_properties_collector.dir/test_properties_collector.cc.o: In function `myrocks::Rdb_tbl_prop_coll::~Rdb_tbl_prop_coll()':
/home/ubuntu/mariadb-10.2-comp2/storage/rocksdb/unittest/.././properties_collector.h:74: undefined reference to `vtable for myrocks::Rdb_tbl_prop_coll'
CMakeFiles/test_properties_collector.dir/test_properties_collector.cc.o: In function `myrocks::Rdb_tbl_prop_coll::~Rdb_tbl_prop_coll()':
/home/ubuntu/mariadb-10.2-comp2/storage/rocksdb/unittest/.././properties_collector.h:74: undefined reference to `vtable for myrocks::Rdb_tbl_prop_coll'
collect2: error: ld returned 1 exit status
storage/rocksdb/unittest/CMakeFiles/test_properties_collector.dir/build.make:107: recipe for target 'storage/rocksdb/unittest/test_properties_collector' failed
make[2]: *** [storage/rocksdb/unittest/test_properties_collector] Error 1
CMakeFiles/Makefile2:8690: recipe for target 'storage/rocksdb/unittest/CMakeFiles/test_properties_collector.dir/all' failed
make[1]: *** [storage/rocksdb/unittest/CMakeFiles/test_properties_collector.dir/all] Error 2
Makefile:160: recipe for target 'all' failed
make: *** [all] Error 2



 Comments   
Comment by Sergei Petrunia [ 2017-04-03 ]

Pushed

commit 5c66eb5c9f7f1da4a08d736ebaec161aeef9383c
Author: Sergei Petrunia <psergey@askmonty.org>
Date:   Mon Apr 3 10:29:40 2017 +0300
 
    Disable compilation of storage/rocksdb/unittest/test_properties_collector
    
    Met additional issues while trying to enable it.

Generated at Thu Feb 08 07:57:39 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.