[MDEV-12430] When Flashback is ON , we can set session binlog_format to other then row Created: 2017-04-03  Updated: 2017-04-03  Resolved: 2017-04-03

Status: Closed
Project: MariaDB Server
Component/s: Replication
Affects Version/s: 10.2.4
Fix Version/s: 10.2.6

Type: Bug Priority: Major
Reporter: Sachin Setiya (Inactive) Assignee: Sachin Setiya (Inactive)
Resolution: Not a Bug Votes: 0
Labels: None


 Description   

When flashback is on and we try to set session binlog_format version , It gives a warning
and sets the binlog_format version to desired one , this should not happen because flashback
works only when binlog_format is row. This works perfectly fine in the case of global binlog_format.



 Comments   
Comment by Elena Stepanova [ 2017-04-03 ]

Only superuser can change binlog format. There is nothing wrong with a superuser being able to change format of the current session. The warning is an appropriate result.

Comment by Sachin Setiya (Inactive) [ 2017-04-03 ]

But if we change binlog format , then we wont be able to flashback . And I think this is a bug ,because
If flash back is on we should not be able to change the binlog_format. And if this is allowed for session
binlog_format , how it is usefull ?

Comment by Elena Stepanova [ 2017-04-03 ]

There are many things that won't work if a superuser changes something else, that's why these permissions are only given to a superuser. Flashback is not anyhow special, it's a small piece of very limited and rather obscure functionality. binlog format is much more important and widely used. Maybe the super user needs to make a change which doesn't need to be flashback-capable, but does require a statement format (a bulk update on a table without PK, if you are looking for an example).

Why does it not worry you that any DDL which any user (not even a superuser) can issue at any time might well totally break flashback? It's not a good enough reason to forbid DDL, right?

Flashback, on the other hand, can only be enabled/disabled at server startup, which means that if it puts a hard restriction on something, the server needs to be restarted every time to avoid this restriction. In a busy environment it's highly undesirable and often impossible.

Comment by Sachin Setiya (Inactive) [ 2017-04-03 ]

oh.. got it , bug closed.

Generated at Thu Feb 08 07:57:39 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.