[MDEV-12419] IMPORT should not look up tablespace in PageConverter::validate() Created: 2017-03-31 Updated: 2017-05-09 Resolved: 2017-05-03 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Affects Version/s: | 10.1, 10.2 |
| Fix Version/s: | 10.1.23, 10.2.6 |
| Type: | Bug | Priority: | Major |
| Reporter: | Marko Mäkelä | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 10.2-ga, regression | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Description |
|
Please add a proper IMPORT test for page_compression and encryption. In 10.2, please remove the function fil_space_found_by_id() altogether. Like fil_space_get(), it is unsafe to use, because the pointer can be stale if the tablespace was dropped just after the call. |
| Comments |
| Comment by Jan Lindström (Inactive) [ 2017-04-04 ] |
|
Removed. |
| Comment by Marko Mäkelä [ 2017-04-17 ] |
|
In which MariaDB versions will this issue be fixed? In the same commit with |
| Comment by Jan Lindström (Inactive) [ 2017-04-28 ] |
|
10.1: commit 765a43605a42c069ede604826ede2d93d72c4fdd Problem was that bpage was referenced after it was already freed This patch should also address following test failures and Removed dict_table_t::is_encrypted and dict_table_t::ibd_file_missing Ported FilSpace class from 10.2 and using that on buf_page_check_corrupt(), Added test cases when enrypted page could be read while doing btr_cur_open_at_index_side_func(), buf_page_get_zip(): Issue error if page read fails. buf_page_get_gen(): Use dberr_t for error detection and buf_mark_space_corrupt(): remove bpage from LRU also when buf_page_check_corrupt(): @return DB_SUCCESS if page has buf_page_io_complete(): use dberr_t for error handling. buf_flush_write_block_low(), btr_pcur_move_to_next_page(): Do not reference page if it is Introduced dict_table_t::is_readable() and dict_index_t::is_readable() dict_stats_update_transient_for_index(), dict0stats.cc: Introduced a dict_stats_report_error function fil_parse_write_crypt_data(): PageConverter::validate(): Removed access to fil_space_t as Fixed error code on innodb.innodb test. Merged test cased innodb-bad-key-change5 and innodb-bad-key-shutdown Removed fil_inc_pending_ops(), fil_decr_pending_ops(), fil_space_verify_crypt_checksum(): Fixed bug found using ASAN Added new tests for discard, rename table and drop (we should allow them Adjusted the test case innodb_bug14147491 so that it does not anymore fil0fil.h: fil_space_acquire_low is not visible function recv_apply_hashed_log_recs() does not return anything. |
| Comment by Marko Mäkelä [ 2017-05-03 ] |
|
This was fixed in the |