[MDEV-12415] Remove sp_name::m_qname Created: 2017-03-31 Updated: 2017-04-07 Resolved: 2017-03-31 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Parser, Stored routines |
| Fix Version/s: | 10.3.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Alexander Barkov | Assignee: | Alexander Barkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | refactoring | ||
| Description |
|
The class sp_name has a member LEX_STRING m_qname. This member is needed only for error reporting purposes. it contains redundant information and is always synchronized with the other two members LEX_STRING members Instead of maintaining the redundant member m_qname we'll introduce two new classes: 1. Database_qualified_name
Under terms of this task we'll derive sp_name and sp_head from this new class Database_qualified_name. Later, under terms of separate tasks, we'll derive more classes from Database_qualified_name. For example, Item_ident is a good candidate for. 2. ErrConvDQName - a new ErrConv family class (in addition to those defined in sql_error.h}
Open question: |
| Comments |
| Comment by Oleksandr Byelkin [ 2017-03-31 ] |
|
OK to push |
| Comment by Alexander Barkov [ 2017-03-31 ] |
|
Pushed to bb-10.2-ext. |