[MDEV-12362] InnoDB tests do not work without mysql-test/include/have_innodb.inc Created: 2017-03-25  Updated: 2017-03-25  Resolved: 2017-03-25

Status: Closed
Project: MariaDB Server
Component/s: Tests
Affects Version/s: 10.1.23
Fix Version/s: N/A

Type: Bug Priority: Minor
Reporter: Igor Pashev Assignee: Unassigned
Resolution: Not a Bug Votes: 0
Labels: tests
Environment:

Linux dream 4.9.0-2-amd64 #1 SMP Debian 4.9.13-1 (2017-02-27) x86_64 GNU/Linux
perl v5.24.1



 Description   

InnoDB tests do not work without mysql-test/include/have_innodb.inc included, although this file says "The test below is redundant".

How to replicate:

1. Comment out inclusion of have_innodb.inc

--- a/mysql-test/t/innodb_ext_key.test
+++ b/mysql-test/t/innodb_ext_key.test
@@ -1,4 +1,4 @@
---source include/have_innodb.inc
+#--source include/have_innodb.inc

2. Run the test:

# ./mysql-test/mysql-test-run innodb_ext_key
Logging: /home/pashev/tmp/server/mysql-test/mysql-test-run.pl  innodb_ext_key
vardir: /home/pashev/tmp/server/build/mysql-test/var
Checking leftover processes...
Removing old var directory...
Creating var directory '/home/pashev/tmp/server/build/mysql-test/var'...
Checking supported features...
MariaDB Version 10.1.22-MariaDB
 - SSL connections supported
Sphinx 'indexer' binary not found, sphinx suite will be skipped
Collecting tests...
Installing system database...
 
==============================================================================
 
TEST                                      RESULT   TIME (ms) or COMMENT
--------------------------------------------------------------------------
 
worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
main.innodb_ext_key                      [ fail ]
        Test ended at 2017-03-25 15:05:21
 
CURRENT_TEST: main.innodb_ext_key
mysqltest: At line 8: query 'SET SESSION STORAGE_ENGINE='InnoDB'' failed: 1286: Unknown storage engine 'InnoDB'
 
The result from queries just before the failure was:
DROP TABLE IF EXISTS t1,t2,t3,t4;
DROP DATABASE IF EXISTS dbt3_s001;
SET SESSION STORAGE_ENGINE='InnoDB';
 
 - saving '/home/pashev/tmp/server/build/mysql-test/var/log/main.innodb_ext_key/' to '/home/pashev/tmp/server/build/mysql-test/var/log/main.innodb_ext_key/'
--------------------------------------------------------------------------
The servers were restarted 0 times
Spent 0.000 of 5 seconds executing testcases
 
Failure: Failed 1/1 tests, 0.00% were successful.
 
Failing test(s): main.innodb_ext_key
 
The log files in var/log may give you some hint of what went wrong.
 
If you want to report this error, please read first the documentation
at http://dev.mysql.com/doc/mysql/en/mysql-test-suite.html
 
mysql-test-run: *** ERROR: there were failing test cases

Verified with:

commit 18de8296182f42cdf663573949a82950b72af8fc
Author: iangilfillan <github@greenman.co.za>
Date:   Thu Mar 9 13:18:40 2017 +0200
 
    MDEV-11964 Add missing stub manpages



 Comments   
Comment by Elena Stepanova [ 2017-03-25 ]

It does not say "the file is redundant", it says "The test below is redundant". It's a big difference.
If you need InnoDB in an MTR test, you should either use the include file or create a cnf/opt file for your test.

Generated at Thu Feb 08 07:57:08 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.