[MDEV-12263] Feature: skipped test file Created: 2017-03-15 Updated: 2017-10-08 Resolved: 2017-10-08 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Documentation |
| Fix Version/s: | 10.0.33, 10.1.29, 10.2.10 |
| Type: | Task | Priority: | Major |
| Reporter: | Michal Schorm | Assignee: | Elena Stepanova |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
| Description |
|
Hi, When we solve some troubles with tests, we list them with comments to a standalone file. Then, we add '--skip-test-list' option, to the testsuite. The code is already in place, I only offer a better documentation and a suggestions to ship that file ( mysql-test/skipped-tests.list ) by default (even if it would be empty - since you disable / enable tests directly in each test file) Take a glimpse at the attachement. It is a patch we use and it is written for Red Hat, but adding macros to the paths should solve it. I don't know how others, but RPM distros - like SUSE - could look into Fedora specfile and ease their maintainers lifes with this |
| Comments |
| Comment by Elena Stepanova [ 2017-03-15 ] |
|
Actually, we already have the file itself in 10.0/10.1, it's called unstable-tests, and it's far from empty. The file is used when a reliable subset of tests is needed (e.g. when tests are a part of the build process), to avoid sporadic and irrelevant failures. Naturally, something can always be added to it based on distribution or architecture specifics (it is also known to happen). For 10.2 it is not maintained yet, but it will be by the time 10.2 goes GA. Inclusion:
Exclusion:
On an additional note, if you are want to enable/disable tests really quickly, depending on your process, it might be easier to use --skip-test rather than --skip-test-list. |
| Comment by Michal Schorm [ 2017-03-16 ] |
|
Great! However, I still believe, the comment in the patch should be reviewed. |
| Comment by Elena Stepanova [ 2017-10-08 ] |
|
https://github.com/MariaDB/server/commit/9b897d663a116c5484dade0404870975fd5a2e68 I've added suggested notes with some changes, and while at that, have also done other modifications. mschorm, I delayed this simple request a lot, sorry about that. Please check the RedHat-related part, if it's already become outdated, I will fix it further. |
| Comment by Michal Schorm [ 2017-10-08 ] |
|
Actually, beacuse this discussion, I removed the mentioned 'rh-skipped-tests.list' and all RH tests, that I want to skip are now appended to the 'unstable-tests' file - as it should be. The important part is about "How to run the testsuite at RH family OSs". |
| Comment by Elena Stepanova [ 2017-10-08 ] |
|
Thanks. I've removed the mention of rh-skipped-tests.list. |