[MDEV-12261] build failure without P_S Created: 2017-03-14  Updated: 2017-04-20  Resolved: 2017-03-15

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.0.30, 10.1.22
Fix Version/s: 10.1.23, 10.0.31

Type: Bug Priority: Blocker
Reporter: Robert Goley Assignee: Sergei Golubchik
Resolution: Fixed Votes: 1
Labels: None
Environment:

Ubuntu 16.04 amd64, GCC 5.4.0


 Description   

Changes to the my_sys.h header related to MDEV-11902 have broken certain build configurations that were working under 10.1.21 and earlier. We build using a specific minimum included set of features. This now causes a build failure on building:

Building C object strings/CMakeFiles/strings.dir/ctype-simple.c.o with the error message:
 
 
 
In file included from /src/mariadb/10.1.22/mariadb-10.1-10.1.22+maria/strings/ctype-simple.c:19:0:
 
/src/mariadb/10.1.22/mariadb-10.1-10.1.22+maria/include/my_sys.h:649:43: error: unknown type name 'PSI_file_key'
 
 extern int my_handler_delete_with_symlink(PSI_file_key key, const char *name,
 
                                           ^
 
strings/CMakeFiles/strings.dir/build.make:374: recipe for target 'strings/CMakeFiles/strings.dir/ctype-simple.c.o' failed
 
make[2]: *** [strings/CMakeFiles/strings.dir/ctype-simple.c.o] Error 1
 
CMakeFiles/Makefile2:3431: recipe for target 'strings/CMakeFiles/strings.dir/all' failed
 
make[1]: *** [strings/CMakeFiles/strings.dir/all] Error 2
 
Makefile:160: recipe for target 'all' failed
 
make: *** [all] Error 2

The CMake command used to configure for building:

cmake -DPLUGIN_LOCALES:STRING="NO" -DPLUGIN_SEMISYNC_MASTER:STRING="NO" -DPLUGIN_FEDERATED:STRING="NO" -DCONNECT_WITH_XMAP:BOOL="0" -DPLUGIN_FTEXAMPLE:STRING="NO" -DPLUGIN_DAEMON_EXAMPLE:STRING="NO" -DPLUGIN_OQGRAPH:STRING="NO" -DPLUGIN_WSREP_INFO:STRING="NO" -DMRN_GROONGA_NORMALIZER_MYSQL_EMBED:BOOL="0" -DPLUGIN_AWS_KEY_MANAGEMENT:STRING="NO" -DCONNECT_WITH_LIBXML2:BOOL="0" -DPLUGIN_INNOBASE:STRING="NO" -DWITH_WSREP:BOOL="0" -DPLUGIN_BLACKHOLE:STRING="NO" -DPLUGIN_AUDIT_NULL:STRING="NO" -DPLUGIN_QUERY_CACHE_INFO:STRING="NO" -DPLUGIN_AUTH_GSSAPI:STRING="NO" -DPLUGIN_PARTITION:STRING="NO" -DPLUGIN_PERFSCHEMA:STRING="NO" -DPLUGIN_XTRADB:STRING="NO" -DPLUGIN_SEMISYNC_SLAVE:STRING="NO" -DPLUGIN_MROONGA:STRING="NO" -DPLUGIN_AUTH_SOCKET:STRING="NO" -DPLUGIN_AUTH_TEST_PLUGIN:STRING="NO" -DWITH_PIC:BOOL="1" -DPLUGIN_AUTH_GSSAPI_CLIENT:STRING="NO" -DPLUGIN_AUTH_PAM:STRING="NO" -DPLUGIN_FEDERATEDX:STRING="NO" -DPLUGIN_DIALOG_EXAMPLES:STRING="NO" -DCONNECT_WITH_JDBC:BOOL="0" -DPLUGIN_SPHINX:STRING="NO" -DPLUGIN_QA_AUTH_SERVER:STRING="NO" -DPLUGIN_SQL_ERRLOG:STRING="NO" -DPLUGIN_QA_AUTH_CLIENT:STRING="NO" -DUSE_ARIA_FOR_TMP_TABLES:BOOL="0" -DPLUGIN_DIALOG:STRING="NO" -DMRN_GROONGA_EMBED:BOOL="0" -DPLUGIN_QUERY_RESPONSE_TIME:STRING="NO" -DPLUGIN_CRACKLIB_PASSWORD_CHECK:STRING="NO" -DPLUGIN_FILE_KEY_MANAGEMENT:STRING="NO" -DPLUGIN_AUTH_0X0100:STRING="NO" -DPLUGIN_METADATA_LOCK_INFO:STRING="NO" -DPLUGIN_ARIA:STRING="NO" -DPLUGIN_ARCHIVE:STRING="NO" -DACLOCAL_EXECUTABLE:FILEPATH="ACLOCAL_EXECUTABLE-NOTFOUND" -DPLUGIN_HANDLERSOCKET:STRING="NO" -DPLUGIN_CONNECT:STRING="NO" -DPLUGIN_SEQUENCE:STRING="NO" -DCONNECT_WITH_ODBC:BOOL="0" -DPLUGIN_QA_AUTH_INTERFACE:STRING="NO" -DWITH_SYSTEMD:STRING="NO" -DPLUGIN_EXAMPLE_KEY_MANAGEMENT:STRING="NO" -DWITH_VALGRIND:BOOL="1" -DPLUGIN_TEST_SQL_DISCOVERY:STRING="NO" -DPLUGIN_FEEDBACK:STRING="NO" -DPLUGIN_MYSQL_CLEAR_PASSWORD:STRING="NO" -DPLUGIN_EXAMPLE:STRING="NO" -DPLUGIN_DEBUG_KEY_MANAGEMENT:STRING="NO" -DPLUGIN_SIMPLE_PASSWORD_CHECK:STRING="NO" -DPLUGIN_SPIDER:STRING="NO" -DPLUGIN_TOKUDB:STRING="NO" -DPLUGIN_SERVER_AUDIT:STRING="NO"  ../



 Comments   
Comment by Bernard Spil [ 2017-03-15 ]

This also affects 10.0

Propose to remove the "Storage engine - MyISAM" tag as it affects more components.

On FreeBSD 11.0-p7 amd64 with clang 3.8.0

[ 10%] Building C object strings/CMakeFiles/strings.dir/ctype-simple.c.o
 
cd /usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/strings && /usr/bin/cc  -DDISABLE_MYSQL_THREAD_H -DHAVE_CONFIG_H -I/usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/include -I/usr/local/include -O2 -fno-strict-aliasing -pipe -march=native  -fstack-protector -DWITH_INNODB_DISALLOW_WRITES -O2 -fno-strict-aliasing -pipe -march=native  -fstack-protector -DDBUG_OFF   -fPIC -o CMakeFiles/strings.dir/ctype-simple.c.o   -c /usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/strings/ctype-simple.c
 
In file included from /usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/strings/ctype-simple.c:19:
 
/usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/include/my_sys.h:652:43: error: unknown type name 'PSI_file_key'; did you
 
      mean 'PSI_file'?
 
extern int my_handler_delete_with_symlink(PSI_file_key key, const char *name,
 
                                          ^~~~~~~~~~~~
 
                                          PSI_file
 
/usr/ports/databases/mariadb101-client/work/mariadb-10.1.22/include/mysql/psi/psi.h:105:25: note: 'PSI_file' declared here
 
typedef struct PSI_file PSI_file;
 
                        ^
 
1 error generated.
 
*** Error code 1

Comment by Robert Goley [ 2017-03-15 ]

Removing MyISAM tag is fine. That was what I was limiting my build down to and this is my first bug report here. Was unsure of all categories it should go in. I had not tested with 10.0 as we are only working with 10.1 here. I do know that this successfully worked with at least 10.1.21 and 10.1.20 for sure. I believe it worked with 10.1.19 and 10.1.18 as well.

Comment by Sergei Golubchik [ 2017-03-15 ]

ragoley, absolutely. That's our internal (in the sense "only really matter to us", not "secret" or "hidden") stuff, you don't need to bother. You're very welcome to go above and beyond the expectations, set Component field, test and enter all versions into AffectedVersions — but you don't have to.

Comment by Bernard Spil [ 2017-03-18 ]

Is this the same error on 5.5.54?

[  0%] Building C object strings/CMakeFiles/strings.dir/ctype-simple.c.o
 
cd /usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/strings && /usr/bin/cc  -DDISABLE_MYSQL_THREAD_H -DHAVE_CONFIG_H -I/usr/local/include -I/usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/include -O2 -fno-strict-aliasing -pipe -march=native  -fstack-protector -O2 -fno-strict-aliasing -pipe -march=native  -fstack-protector -DDBUG_OFF   -fPIC -o CMakeFiles/strings.dir/ctype-simple.c.o   -c /usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/strings/ctype-simple.c
 
In file included from /usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/strings/ctype-simple.c:19:
 
In file included from /usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/include/my_sys.h:34:
 
In file included from /usr/ports/databases/mariadb55-client/work/mariadb-5.5.54/include/my_pthread.h:750:
 
In file included from /usr/local/include/mysql/psi/mysql_thread.h:57:
 
/usr/local/include/mysql/psi/psi.h:40:2: error: "You must include my_global.h in the code for the build to be correct."
 
#error "You must include my_global.h in the code for the build to be correct."
 
 ^
 
1 error generated.

Comment by Sergei Golubchik [ 2017-03-18 ]

This must be a different bug. Original report was about "error: unknown type name 'PSI_file_key'" and it did not show up in 5.5, I've tested that.
Could you report that separately, please?

Generated at Thu Feb 08 07:56:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.