[MDEV-12199] Split Item_func_{abs|neg|int_val}::fix_length_and_dec() into methods in Type_handler Created: 2017-03-07  Updated: 2017-04-07  Resolved: 2017-03-10

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 10.3.0

Type: Task Priority: Major
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: datatype

Issue Links:
Blocks
blocks MDEV-4912 Data type plugin API version 1 Closed
Sprint: 10.2.5-1

 Description   

The following methods:

Item_func_neg::fix_length_and_dec()
Item_func_abs::fix_length_and_dec()
Item_func_int_val::fix_length_and_dec()

have switches on arg[0]->cast_to_int_type().
This is not friendly to pluggable data types.

Under term of this task we'll split implementations of these methods into new methods in Type_handler:

virtual bool Item_func_abs_fix_length_and_dec(Item_func_abs *) const;
virtual bool Item_func_int_val_fix_length_and_dec(Item_func_int_val *) const;
virtual bool Item_func_neg_fix_length_and_dec(Item_func_neg *) const;



 Comments   
Comment by Alexey Botchkov [ 2017-03-10 ]

Ok to push.

Comment by Alexander Barkov [ 2017-03-10 ]

Pushed to bb-10.2-ext

Generated at Thu Feb 08 07:55:53 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.