[MDEV-12196] MariaRocks: compile failure on Windows Created: 2017-03-07  Updated: 2017-03-14  Resolved: 2017-03-14

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergei Petrunia Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
is part of MDEV-9658 Make MyRocks in MariaDB stable Closed
is part of MDEV-10966 Packaging for MariaRocks Closed

 Description   

There is a compile failure on windows:

http://buildbot.askmonty.org/buildbot/builders/win32-packages/builds/2395/steps/build/logs/stdio

d:\win32-packages\build\src\storage\rocksdb\./rdb_threads.h(91): error C2062: type 'void' unexpected (compiling source file D:\win32-packages\build\src\storage\rocksdb\rdb_mariadb_server_port.cc) [D:\win32-packages\build\storage\rocksdb\rocksdb_se.vcxproj]
 
d:\win32-packages\build\src\storage\rocksdb\./rdb_threads.h(91): error C2238: unexpected token(s) preceding ';' (compiling source file D:\win32-packages\build\src\storage\rocksdb\rdb_mariadb_server_port.cc) [D:\win32-packages\build\storage\rocksdb\rocksdb_se.vcxproj]

wlad, the error is in the new code you've added when porting so I assume it should be easy to fix.
Is pthread_join #define'd to nothing under some circumstances? Can one use VOID ...

 Comments   
Comment by Sergei Petrunia [ 2017-03-14 ]

This and one similar issue have been fixed and now buildbot shows compilation succeeds on windows. Closing

Generated at Thu Feb 08 07:55:52 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.