[MDEV-12188] information schema - errors populating fail to free memory, unlock mutexes Created: 2017-03-07 Updated: 2018-05-24 Resolved: 2017-05-15 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB, Storage Engine - XtraDB |
| Affects Version/s: | 10.0, 10.1, 10.2 |
| Fix Version/s: | 10.1.24, 10.0.31, 10.2.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | Daniel Black | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | information_schema, innodb | ||
| Issue Links: |
|
||||||||
| Description |
|
Given the OK macro used in innodb does a DBUG_RETURN(1) on expression failure the innodb implementation has a number of errors in i_s.cc In the case of the OK expression failing:
sync/sync0arr.cc appears safe in its OK usage (from 10.1 onwards) In addition to the requirement for this fix, perhaps something like
10.0,10.2 are still using fprintf(stderr. |
| Comments |
| Comment by Marko Mäkelä [ 2017-05-15 ] |
|
I think that I found some correctness problems in the patch that serg came up with. |
| Comment by Marko Mäkelä [ 2017-05-15 ] |
| Comment by Jan Lindström (Inactive) [ 2017-05-15 ] |
|
I do not see anything really broken, check that one memory allocation where I had question about release. ok to push. |
| Comment by Marko Mäkelä [ 2017-05-15 ] |
|
In the final version, I simplified the code a little. |