[MDEV-12146] Deprecate and remove innodb_instrument_semaphores Created: 2017-02-28  Updated: 2017-03-01  Resolved: 2017-03-01

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.2
Fix Version/s: 10.2.5, 10.3.0

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-7618 Improve semaphore instrumentation Closed

 Description   

In InnoDB, there is a configuration parameter innodb_instrument_semaphores. The parameter seems to only affect the rw-lock X-latch acquisition. Extra fields are added to rw_lock_t to remember one X-latch holder or waiter. These fields are not being consulted or reported anywhere. This is basically only adding code bloat.

If the intention is to debug hangs or deadlocks, we have better tools for that in the debug server, and for the non-debug server, core dumps can reveal a lot. For example, the mini-transaction memo records the currently held buffer block or index rw-locks, to be released at mtr_t::commit().

The configuration parameter innodb_instrument_semaphores should be deprecated in 10.2.5 and removed in 10.3.0.



 Comments   
Comment by Marko Mäkelä [ 2017-02-28 ]

bb-10.2-marko

Comment by Jan Lindström (Inactive) [ 2017-02-28 ]

ok to push.

Generated at Thu Feb 08 07:55:28 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.