[MDEV-12138] mysqltest: source inside a loop Created: 2017-02-27 Updated: 2023-04-27 |
|
| Status: | Open |
| Project: | MariaDB Server |
| Component/s: | Scripts & Clients, Tests |
| Affects Version/s: | 5.5, 10.0, 10.1, 10.2 |
| Fix Version/s: | 10.4 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Sergei Golubchik | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 2 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
The current implementation of caching in mysqltest (q_lines, parser) breaks if the source command is executed conditionally in a loop. There is a "fix" for that — commit fe3ea31d93 — where the source command is executed on the first iteration of a loop even if it should've been skipped, just to read the file into a cache. This is, of course, wrong, because it fails if the file name is not available on the first iteration, or if t changes between iterations:
|
| Comments |
| Comment by Amol Holani [ 2017-03-12 ] |
|
Hi Sergei, |
| Comment by Daniel Black [ 2017-03-12 ] |
|
https://github.com/MariaDB/server/blob/10.1/client/mysqltest.cc |
| Comment by Amol Holani [ 2017-03-12 ] |
|
Thanks for quick reply. |