[MDEV-12116] Tables created during backup may be missed after restore Created: 2017-02-23  Updated: 2020-08-25  Resolved: 2018-08-14

Status: Closed
Project: MariaDB Server
Component/s: Backup
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Andrii Nikitin (Inactive) Assignee: Marko Mäkelä
Resolution: Duplicate Votes: 1
Labels: None

Attachments: File mariabackup-bug1291299.sh.err     File mariabackup-ddl.sh.err     File xtrabackup-bug1291299.sh.err     File xtrabackup-ddl.sh.err     File xtrabackup244-bug1291299.sh.err     File xtrabackup244-ddl.sh.err    
Issue Links:
PartOf
is part of MDEV-16791 mariabackup : allow consistent backup... Closed
Relates
relates to MDEV-14095 Concurrent DDL can break xtrabackup-v... Closed

 Description   

The same test case passes with xtrabackup 2.4.5 and fails in current 10.1.22 (UPDATE 4-Apr-17 : the test passes with 2.3.6 and 2.3.7 as well)

https://github.com/percona/percona-xtrabackup/blob/2.3/storage/innobase/xtrabackup/test/t/bug1291299.sh

Needs investigation and may be converted to bug as I am not sure what priority should be and if this is really unexpected behavior or just different implementation of place where sync point is created.

 Comments   
Comment by Andrii Nikitin (Inactive) [ 2017-02-23 ]

Another test case and logs https://github.com/percona/percona-xtrabackup/blob/2.3/storage/innobase/xtrabackup/test/t/ddl.sh
(2.4.4 passes on both tests as well)

Comment by Vladislav Vaintroub [ 2017-02-23 ]

Does it pass with 2.3.6 ? this is our baseline

Comment by Andrii Nikitin (Inactive) [ 2017-04-04 ]

The test passes with following setups:
Percona Xtrabackup 2.3.6 taking backup from Server MariaDB 10.1.22
Percona Xtrabackup 2.3.7 taking backup from Server MariaDB 10.1.22
Percona Xtrabackup 2.3.6 taking backup from Server of current bb-10.1-xtrabackup
Percona Xtrabackup 2.3.7 taking backup from Server of current bb-10.1-xtrabackup

And fails on the same Servers with mariabackup from bb-10.1-xtrabackup with message:
bash: Cannot find backup/test/t1.ibd

Maybe I am missing something, but I think this needs to be looked at by Marko or Jan

Comment by Andrii Nikitin (Inactive) [ 2017-10-28 ]

Just for reference - it is still valid in current 10.1

Comment by Andrii Nikitin (Inactive) [ 2017-10-28 ]

One conceptual solution to the problem may be implementing MDEV-5336 LOCK TABLES FOR BACKUP and then --lock-ddl option in mariabackup

Comment by Marko Mäkelä [ 2017-10-28 ]

Somewhat related to this is https://bugs.mysql.com/bug.php?id=71017.

I think that the correct solution would be to implement a server-side backup command. With server-side backup, I do not see a need to prevent concurrent DDL operations. Newly created or renamed files would just be logged in the backup output stream.

If the test really passes with xtrabackup 2.3, then we definitely need to do something about mariabackup.

Comment by Vladislav Vaintroub [ 2018-08-14 ]

Fixed with MDEV-16791

Generated at Thu Feb 08 07:55:14 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.