[MDEV-11965] -Werror should not appear in released tarballs Created: 2017-02-01 Updated: 2017-11-02 Resolved: 2017-03-10 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Compiling, Server |
| Affects Version/s: | 10.1.21 |
| Fix Version/s: | 10.1.22, 10.2.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | Michal Schorm | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Fedora 26 |
||
| Issue Links: |
|
||||||||
| Sprint: | 10.1.22 | ||||||||
| Description |
|
Hello, there is a discussion on the RHBZ, about -Werror option. The conclusion, from my POV as a maintainer is, that -Werror flag is should be removed from stable released tarballs. It breaks things, when teh environments is changing, which is quite often in Fedora. One way or another, I'd be gratefull for a fast decission (if I can wait for next version, or If I should fix it through SPEC file downstream way) In comment 14 the observation is pointed out, that -Werror is maybe currently used only for PerconaFT sub-directory. |
| Comments |
| Comment by Michal Schorm [ 2017-02-13 ] | ||||||||||||||||
|
The problem is, that with the option used, MariaDB can't be compiled for x86_64 architecture on current Fedora rawhide (will be F26), because one of the warnings is marked as error. However, this line remove the option from PerconaFT cmake setup and make the whole MariaDB able to compile:
Here is the error:
|