[MDEV-11824] Allow ROW_FORMAT=DYNAMIC in the InnoDB system tablespace Created: 2017-01-17  Updated: 2017-01-18  Resolved: 2017-01-18

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.2.3
Fix Version/s: 10.2.4

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: compat57

Issue Links:
Relates
relates to MDEV-11816 Disallow CREATE TEMPORARY TABLE…ROW_F... Closed

 Description   

When MySQL 5.7 introduced innodb_default_row_format and made ROW_FORMAT=DYNAMIC the default, it became possible to create any ROW_FORMAT tables in the InnoDB system tablespace, except ROW_FORMAT=COMPRESSED.

See for example the file mysql-test/suite/innodb/r/create_tablespace.result which contains the following line:

test/t_system        innodb_system   33      5       Dynamic 0       System

For logical behaviour, we should stop refusing explicitly specified ROW_FORMAT=DYNAMIC when innodb_file_per_table=0.
(We should still reject ROW_FORMAT=DYNAMIC and ROW_FORMAT=COMPRESSED when the deprecated setting innodb_file_format=Antelope is in effect.)

 Comments   
Comment by Marko Mäkelä [ 2017-01-17 ]

The patch is simple after MDEV-11816: just remove one check from the code, and adjust a few tests.

Comment by Marko Mäkelä [ 2017-01-17 ]

http://lists.askmonty.org/pipermail/commits/2017-January/010453.html

Comment by Jan Lindström (Inactive) [ 2017-01-17 ]

ok to push.

Generated at Thu Feb 08 07:52:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.