[MDEV-11743] Add environment variables for unit test which uses server Created: 2017-01-08  Updated: 2017-05-26  Resolved: 2017-05-26

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Fix Version/s: 10.2.5

Type: Task Priority: Critical
Reporter: Oleksandr Byelkin Assignee: Georg Richter
Resolution: Fixed Votes: 0
Labels: None

Attachments: File MDEV-11743.patch    
Sprint: 10.2.4-1, 10.2.4-2, 10.2.5-1

 Description   

Add:
MYSQL_TEST_HOST, MYSQL_TEST_USER, MYSQL_TEST_PORT, MYSQL_TEST_DB



 Comments   
Comment by Georg Richter [ 2017-03-09 ]

Required changes for Connector/C already pushed. Connector/C uses environment variables MASTER_MYSOCK and MASTER_MYPORT (still open: host, user and schema).

Comment by Sergei Golubchik [ 2017-03-12 ]

Comments:

  1. I presume new commands you've added to mysql-test/lib/generate-ssl-certs.sh don't generate new certificates, but only convert existing ones to something else? I mean, the expiration date is the same as for other certs? This script creates a bunch of certs, that all expire at the same day and this script is used to recreate them. If different certs will expire at different dates, it'll be inconvenient to maintain.
  2. In C/C: Using CONFIGURE_FILE to replace @CERT_PATH@ is rather hackish. A proper way to do it is to use ADD_DEFINITIONS(-DCERT_PATH=${CERT_PATH} (or SET_PROPERTY to do it only for one file). But it's still wrong — you cannot use compile-time path in tests, because the tests could've been moved (e.g. packaged and installed). Use simply std_data, tests are run from the test dir. Or $MYSQL_TEST_DIR/std_data or even $SECURE_LOAD_PATH.
Generated at Thu Feb 08 07:52:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.