[MDEV-11684] post-10.1-merge fixes Created: 2016-12-29 Updated: 2017-01-03 Resolved: 2017-01-03 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER, Storage Engine - InnoDB |
| Affects Version/s: | 10.2 |
| Fix Version/s: | 10.2.4 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Sergei Golubchik | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
10.1 is merged into 10.2 now. Two issues are left to fix:
|
| Comments |
| Comment by Jan Lindström (Inactive) [ 2016-12-30 ] |
|
No issue on read_page0 (number of times page 0 is read) vs page_0_crypt_read (is crypt data read or not). |
| Comment by Jan Lindström (Inactive) [ 2016-12-30 ] |
|
http://lists.askmonty.org/pipermail/commits/2016-December/010358.html |
| Comment by Sergei Golubchik [ 2016-12-30 ] |
|
jplindst, fil_space_t::read_page0 is bool, it cannot be "number of times". |
| Comment by Jan Lindström (Inactive) [ 2016-12-30 ] |
|
Ah, confused i to ulint_ctr_64_t page0_read |
| Comment by Marko Mäkelä [ 2017-01-03 ] |
|
This patch appears to address serg’s comment: |
| Comment by Jan Lindström (Inactive) [ 2017-01-03 ] |
|
commit a0d396fd3f5f86e09f602ac9f76b8d9f2e739221 10.1 is merged into 10.2 now. Two issues are left to fix: (1) innochecksum tool did not compile after merge because extra/CMakeLists.txt: Added fil/fil0crypt.cc as dependency innochecksum.cc: If we think page is encrypted i.e. fil0crypt.cc: add #ifdef UNIV_INNOCHECKSUM to be able to compile (2) read_page0 is not needed and thus removed. |