[MDEV-11456] corruption in page 1 for big innodb tables in compressed format with mdb encryption Created: 2016-12-02 Updated: 2016-12-08 Resolved: 2016-12-08 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Backup |
| Affects Version/s: | 10.1.20 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Andrii Nikitin (Inactive) | Assignee: | Jan Lindström (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
| Description |
|
Attached mtr test results in following errors during restore: When I reduce number of rows - test most likely to succeed. |
| Comments |
| Comment by Andrii Nikitin (Inactive) [ 2016-12-04 ] | |||||||||||||||||||||||||||||||||||||
|
I've tried the same with percona-xtrabackup 2.3.6 and the error is still there, so it is not specific to Backup component, thus closing at the moment | |||||||||||||||||||||||||||||||||||||
| Comment by Vladislav Vaintroub [ 2016-12-04 ] | |||||||||||||||||||||||||||||||||||||
|
I'd rather have this open, we have to support our compression and encryption, Percona's xtrabackup does not have to. | |||||||||||||||||||||||||||||||||||||
| Comment by Andrii Nikitin (Inactive) [ 2016-12-04 ] | |||||||||||||||||||||||||||||||||||||
|
yeah, my bad : without encryption no error is shown. | |||||||||||||||||||||||||||||||||||||
| Comment by Vladislav Vaintroub [ 2016-12-06 ] | |||||||||||||||||||||||||||||||||||||
|
Jan, could you have a look? /* check pages for corruption and re-read if necessary. i.e. in case of if (buf_page_is_corrupted(TRUE, page, cursor->zip_size)) { | |||||||||||||||||||||||||||||||||||||
| Comment by Vladislav Vaintroub [ 2016-12-06 ] | |||||||||||||||||||||||||||||||||||||
|
This would be fixed xb_compressed_encrypted.test , applicable to current bb-10.1-wlad-xtrabackup
| |||||||||||||||||||||||||||||||||||||
| Comment by Jan Lindström (Inactive) [ 2016-12-07 ] | |||||||||||||||||||||||||||||||||||||
|
Yes, you need to do buf_page_decrypt_after_read(bpage) before you try to compare checksums... | |||||||||||||||||||||||||||||||||||||
| Comment by Jan Lindström (Inactive) [ 2016-12-08 ] | |||||||||||||||||||||||||||||||||||||
|
commit 0abfd68330293b8fa6c732e3128fbc44f5d41036 Verify encrypted page checksum using the correct method. | |||||||||||||||||||||||||||||||||||||
| Comment by Andrii Nikitin (Inactive) [ 2016-12-08 ] | |||||||||||||||||||||||||||||||||||||
|
For me current mtr test xb_compressed_encrypted.test is still crashing occasionally with stack below: xtrabackup.exe!mach_read_from_4()[mach0data.ic:186] It appears in debugger that memory passed to mach_read_from_4 above is either corrupted or garbage | |||||||||||||||||||||||||||||||||||||
| Comment by Vladislav Vaintroub [ 2016-12-08 ] | |||||||||||||||||||||||||||||||||||||
|
I had this, too. |