[MDEV-11401] AliSQL: [Feature] Issue#26 ADD TokuDB COMPRESSION FORMAT ROW_TYPE SUPPORT Created: 2016-11-29  Updated: 2016-11-30  Resolved: 2016-11-30

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - TokuDB
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergey Vojtovich Assignee: Lixun Peng
Resolution: Won't Do Votes: 0
Labels: None

Epic Link: AliSQL patches

 Description   

Description:
------------
port from:
http://bazaar.launchpad.net/~laurynas-biveinis/percona-server/tokudb-compression/revision/517

https://github.com/alibaba/AliSQL/commit/3446841f5cc4784868e7843fa688667546627239



 Comments   
Comment by Sergey Vojtovich [ 2016-11-30 ]

plinux, I think this is not needed similarly to MDEV-11400. In MariaDB you don't need to modify whole lot of files to add new table option. E.g. TokuDB compression is implemented like: https://github.com/MariaDB/server/blob/10.1/storage/tokudb/tokudb_sysvars.cc#L1142

Comment by Sergey Vojtovich [ 2016-11-30 ]

Sorry, I meant MDEV-11399.

Comment by Lixun Peng [ 2016-11-30 ]

svoj MariaDB prefer to use Session variables, but we prefer to modify the syntax, different styles, but the effect is the same. So you can ignore this issue.

Comment by Sergey Vojtovich [ 2016-11-30 ]

Not really, CREATE TABLE syntax is also extended in MariaDB and it is covered by test cases. E.g. tokudb_mariadb.compression has:

create table t4 (a text) engine=tokudb compression=tokudb_lzma;

Closing per plinux comment.

Generated at Thu Feb 08 07:49:40 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.