[MDEV-11399] AliSQL: [Feature] Issue#26 ADD SECONDARY CLUSTERING KEY SUPPORT Created: 2016-11-29 Updated: 2016-11-30 Resolved: 2016-11-30 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - TokuDB |
| Fix Version/s: | N/A |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Lixun Peng |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Epic Link: | AliSQL patches |
| Description |
|
https://github.com/alibaba/AliSQL/commit/cf5e15eade48b67a82d413cb3b4289bbfefe25cf |
| Comments |
| Comment by Sergey Vojtovich [ 2016-11-29 ] |
|
plinux, I guess this was needed for TokuDB support. I believe MariaDB has this (somewhat differently) implemented. Is there anything of interest in this patch? |
| Comment by Lixun Peng [ 2016-11-30 ] |
|
svoj I can the parts of this patch's code exist in MariaDB, but not all (maybe MariaDB implement by different way), could you please show me the commit id about how MariaDB implemenet this patch's feature? |
| Comment by Sergey Vojtovich [ 2016-11-30 ] |
|
I believe it was added in this patch: https://github.com/MariaDB/server/commit/3631146442bc09e5129334774b4bcdf2470a4b27 Please note that in MariaDB you don't need to edit a whole lot of files to extend SQL syntax with new index option. E.g. TokuDB CLUSTERING index option is implemented this way: https://github.com/MariaDB/server/blob/10.2/storage/tokudb/tokudb_sysvars.cc#L1133 |
| Comment by Lixun Peng [ 2016-11-30 ] |
|
svoj As we checked, MariaDB has the same feature, but different implement, so you needn't to do anything for this issue. |
| Comment by Sergey Vojtovich [ 2016-11-30 ] |
|
Closing per plinux comment. |