[MDEV-11384] AliSQL: [Feature] Issue#19 BUFFER POOL LIST SCAN OPTIMIZATION Created: 2016-11-29 Updated: 2021-03-09 Resolved: 2021-03-09 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Fix Version/s: | 10.6.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Epic Link: | AliSQL patches | ||||||||||||||||||||||||||||||||
| Description |
|
https://github.com/alibaba/AliSQL/commit/2645293fb0c1ed398f7243da2c14ab07572045b0 |
| Comments |
| Comment by Marko Mäkelä [ 2017-11-17 ] |
|
The commit includes two things: a backport of a feature from MySQL 5.7 to AliSQL 5.6, and a change to split a "processed blocks" counter into "flushed blocks" and "evicted blocks" counters. MariaDB 10.2+ is based on MySQL 5.7, so the only addition of this contribution is the split of the counter. I would prefer to do it differently, if it is OK from a performance point of view:
plinux, I think that the above is feasible to do in MariaDB 10.3. |
| Comment by Marko Mäkelä [ 2021-02-26 ] |
|
In I would not extend the monitor interface with new counters; that interface should hopefully be removed (MDEV-15706) and replaced with innodb_status_variables. We actually do have MONITOR_LRU_BATCH_EVICT_TOTAL_PAGE, which is being incremented in buf_do_LRU_batch() (and not exposed elsewhere). We also have a buf_flush_page_count (innodb_buffer_pool_pages_flushed) that is incremented in each call of buf_flush_page(). That counter does not distinguish the two types of page writes (checkpoint or eviction). It seems that we could address this by extending innodb_status_variables as follows:
|
| Comment by Marko Mäkelä [ 2021-03-08 ] |
| Comment by Vladislav Vaintroub [ 2021-03-08 ] |
|
Looks good to me, |
| Comment by Marko Mäkelä [ 2021-03-08 ] |
|
wlad, thank you. I filed |
| Comment by Marko Mäkelä [ 2021-03-09 ] |
|
The first part (MySQL WL#7047) was already part of MariaDB Server 10.2 (via MySQL 5.7). The second part (the counters) were mostly done in MariaDB 10.5.7 ( |