[MDEV-11382] AliSQL: [Feature] Issue#9: PROVIDE ADAPTIVE ALGORITHM FOR INNODB CONCURRENCY TICKETS Created: 2016-11-29 Updated: 2021-03-09 Resolved: 2021-03-09 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Fix Version/s: | N/A |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Axel Schwenke |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | performance | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Epic Link: | AliSQL patches | ||||||||
| Description |
|
https://github.com/alibaba/AliSQL/commit/e6abc82cddaae0f8dc63ef976f7662a40443de8b |
| Comments |
| Comment by Marko Mäkelä [ 2017-11-17 ] |
|
I think that the connection throttling would better be moved out from InnoDB, and it should apply to all storage engines. Maybe this should be part of the thread pool? |
| Comment by Marko Mäkelä [ 2017-11-17 ] |
|
wlad, what is your opinion? |
| Comment by Vladislav Vaintroub [ 2017-11-17 ] |
|
Limiting concurrency, while avoiding starvation is already part of the threadpool. in "generic" threadpool implementation, we try to have 1 thread active per thread-group (there is usually as many groups as CPUs, so 1 thread per CPU is actively executing)- However, there is also a timer thread that checks every now and then for long running queries, and if it detects starvation (no new queries executed for specific time period), new threads are started to execute queries, even if this would "overcommit" CPUs. There is no black magic, no tickets, no "entering innodb mode" , "read-only selects" in the threadpool design. |
| Comment by Marko Mäkelä [ 2019-04-30 ] |
|
I ported the AliSQL change to the latest MariaDB 10.2. axel, can you please benchmark MDEV-11382-10.2.patch |
| Comment by Axel Schwenke [ 2019-04-30 ] |
|
plinux can you give me a hint, what kind of workloads this patch is adressing? I'm sure you did some internal tests to validate it. What did you use? |
| Comment by Marko Mäkelä [ 2021-03-09 ] |
|
In |