[MDEV-11349] Fix warnings from clang 4.0.0 and Valgrind 3.12.0 Created: 2016-11-25 Updated: 2016-11-25 Due: 2016-11-25 Resolved: 2016-11-25 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB, Storage Engine - XtraDB |
| Affects Version/s: | None |
| Fix Version/s: | 10.1.20, 10.2.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Marko Mäkelä | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Fix most InnoDB and XtraDB warnings from clang 4.0. In functions that declare pointer parameters as nonnull, Use #ifdef instead of #if when checking for a configuration flag. Clang says that left shifts of negative values are undefined. Some functions that were defined as UNIV_INLINE were declared as ibuf_merge_or_delete_for_page() could pass bitmap_page=NULL to Fix some bogus-looking Valgrind warnings. buf_block_init(): Initialize buf_page_t::flush_type. mach_write_to_1(), mach_write_to_2(), mach_write_to_3(): |
| Comments |
| Comment by Sergey Vojtovich [ 2016-11-25 ] |
|
Note that https://github.com/MariaDB/server/pull/259 suggest some clang fixes for InnoDB too. Normally it means that we should prioritise community contribution over internal development. But if fixes are implemented already, feel free to use them. |