[MDEV-10965] Add MyRocks into MariaDB repository Created: 2016-10-06  Updated: 2017-03-14  Resolved: 2017-03-14

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Sergei Petrunia Assignee: Sergei Petrunia
Resolution: Fixed Votes: 2
Labels: None

Issue Links:
PartOf
is part of MDEV-9658 Make MyRocks in MariaDB stable Closed

 Description   

How do we add MyRocks into MariaDB, and how do we merge it?

In the facebook/mysql tree it is done as follows:

  • /rocksdb - a submodule pointing to rocksdb repo
    *storage/rocksdb - MyRocks code.

Results of discussions with serg:

  • We can put the storage engine into storage/rocksdb
  • The preferered place to put the submodule is {{ storage/rocksdb/rocksdb}}.
  • Merging *
    Sregei uses a technique called "Merge Tree" for TokuDB merges.
    The idea is to create a tree on github where you re-commit the newer versions.

cp tokudb-tree/*.cc  mariadb-merge-tree/
git commit -m "TokuDB version X.Y.Z"
cd mariadb-tree
git pull --merge mariadb-merge-tree

This destroys the revision history in MyRocks. But this is the best thing we can get it seems.



 Comments   
Comment by Sergei Petrunia [ 2016-10-07 ]

The merge tree is at:
https://github.com/MariaDB/mergetrees/tree/merge-myrocks

The working (doesn't compile yet) tree is at:
https://github.com/MariaDB/server/tree/10.2-mariarocks

Comment by Sergei Petrunia [ 2017-03-14 ]

The process was set up as described, several merges are already done using this approach. Closing.

Generated at Thu Feb 08 07:46:16 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.